diff options
| author | Varshit B Pandya <varshit.b.pandya@intel.com> | 2022-07-01 17:57:43 +0530 |
|---|---|---|
| committer | Martin L Roth <gaumless@tutanota.com> | 2022-07-16 22:54:38 +0000 |
| commit | 4060df41b2fa706cf9d674c84fa6443426d0b4d3 (patch) | |
| tree | 834a5d9a26a85990787d84af902090b294a231e0 | |
| parent | 86f410479ca91bd9cb84c5565489efe15bc2f292 (diff) | |
drivers/intel/dptf: Correct UID for TBAT device
As per Intel Dynamic Tuning Spec revision 1.3.13, section 14.1.2 TBAT
_UID should match the _UID implemented for battery device ACPI object
for OS
_UID for TBAT is currently set to "TBAT" but should be 1.
Battery device is define at src/ec/google/chromeec/acpi/battery.asl
Setting _UID to 1 because right now ChromeOS is the only user
of DPTF driver
TEST: Build and boot brya0
Signed-off-by: Varshit B Pandya <varshit.b.pandya@intel.com>
Change-Id: I1e4474e59cf01f937fbd51e5b674a609f0c47625
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65605
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
| -rw-r--r-- | src/drivers/intel/dptf/dptf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 3cfd23c1d8..450451082f 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -406,7 +406,7 @@ static void write_create_tbat(const struct dptf_platform_info *platform_info) acpigen_write_name("_HID"); if (platform_info->tbat_device_hid != NULL) dptf_write_hid(platform_info->use_eisa_hids, platform_info->tbat_device_hid); - acpigen_write_name_string("_UID", "TBAT"); + acpigen_write_name_string("_UID", "1"); acpigen_write_name_string("_STR", DEFAULT_BATTERY_STR); acpigen_write_name_integer("PTYP", DPTF_GENERIC_PARTICIPANT_TYPE_BATTERY); acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); |