summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2022-11-12 22:26:13 +0100
committerFelix Held <felix-coreboot@felixheld.de>2022-11-17 13:17:16 +0000
commit2e9849aa02f820a0ba93aafaa77404f6b19849df (patch)
tree58f87f16f98f939f3f92e25159ba983c565a8c7d
parent8e679f72e9e496dc84f463d56577f8edc6ab744e (diff)
mb/supermicro/x11-lga1151-series: Fix CMOS options
The `hyper_threading` CMOS option was hooked up to the wrong enumeration and lacked a default value in `cmos.default`. Thus, use the correct enum for the `hyper_threading` option, remove the now-unused "backwards" enum and provide a default value in `cmos.default`. Change-Id: I2ee9ced2881ed5e348e84a35e8abd6b7a363d936 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/69491 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-by: Sean Rhodes <sean@starlabs.systems> Reviewed-by: Felix Singer <felixsinger@posteo.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/supermicro/x11-lga1151-series/cmos.default1
-rw-r--r--src/mainboard/supermicro/x11-lga1151-series/cmos.layout4
2 files changed, 2 insertions, 3 deletions
diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.default b/src/mainboard/supermicro/x11-lga1151-series/cmos.default
index d56495357c..a93c147abe 100644
--- a/src/mainboard/supermicro/x11-lga1151-series/cmos.default
+++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.default
@@ -1,3 +1,4 @@
boot_option=Fallback
debug_level=Debug
+hyper_threading=Enable
power_on_after_fail=Enable
diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout
index 46703e6549..07f8233d33 100644
--- a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout
+++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout
@@ -17,7 +17,7 @@ entries
# -----------------------------------------------------------------
# coreboot config options: cpu
-400 1 e 2 hyper_threading
+400 1 e 1 hyper_threading
# -----------------------------------------------------------------
# coreboot config options: southbridge
@@ -38,8 +38,6 @@ enumerations
#ID value text
1 0 Disable
1 1 Enable
-2 0 Enable
-2 1 Disable
4 0 Fallback
4 1 Normal
6 0 Emergency