diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2024-11-19 08:43:34 +0100 |
|---|---|---|
| committer | Patrick Rudolph <patrick.rudolph@9elements.com> | 2024-11-21 08:37:07 +0000 |
| commit | 22fc6d10d5d7b423fa257d34849ccbe6f8405cc2 (patch) | |
| tree | 72701d6cb38e438c5f7fab04898b6ff941d4aec6 | |
| parent | c89ccaf2816a781ae0acb997557aed7d8cf10b7c (diff) | |
soc/intel/xeon_sp: Fix SRAT debug prints
- Drop duplicated fields
- Drop fields filled with constant values
- Drop SRAT prefix for sysmemmap entries
- Print all zeros when concatenating two hex numbers
Change-Id: I379aeb6fcd2e28665c7d592b0639db3c1b4caa9b
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85189
Reviewed-by: Shuo Liu <shuo.liu@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/intel/xeon_sp/uncore_acpi.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c index 2d0baf9b40..b64271ee0b 100644 --- a/src/soc/intel/xeon_sp/uncore_acpi.c +++ b/src/soc/intel/xeon_sp/uncore_acpi.c @@ -84,9 +84,9 @@ static void acpi_fill_srat_memory(int *cnt, acpi_srat_mem_t *current, addr = ((uint64_t)e->BaseAddress << MEM_ADDR_64MB_SHIFT_BITS); size = ((uint64_t)e->ElementSize << MEM_ADDR_64MB_SHIFT_BITS); - printk(BIOS_DEBUG, "SRAT: sysmemmap addr: 0x%llx, BaseAddress: 0x%x, size: 0x%llx, " - "ElementSize: 0x%x, type: %d, reserved: %d\n", addr, e->BaseAddress, - size, e->ElementSize, e->Type, is_memtype_reserved(e->Type)); + printk(BIOS_DEBUG, " sysmemmap addr: 0x%llx, size: 0x%llx, " + "type: %d, reserved: %d\n", addr, size, e->Type, + is_memtype_reserved(e->Type)); /* skip reserved memory region */ if (is_memtype_reserved(e->Type)) @@ -122,9 +122,9 @@ static void acpi_fill_srat_memory(int *cnt, acpi_srat_mem_t *current, } if (!skip) { - printk(BIOS_DEBUG, "SRAT: adding memory %d entry length: %d, addr: 0x%x%x, " - "length: 0x%x%x, proximity_domain: %d, flags: %x\n", - *cnt, srat.length, srat.base_address_high, srat.base_address_low, + printk(BIOS_DEBUG, "SRAT: memory %d: addr=0x%x%08x, " + "length=0x%x%08x, proximity_domain=%d, flags=%x\n", + *cnt, srat.base_address_high, srat.base_address_low, srat.length_high, srat.length_low, srat.proximity_domain, srat.flags); memcpy(current, &srat, sizeof(acpi_srat_mem_t)); |