diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2022-08-26 16:00:59 -0600 |
|---|---|---|
| committer | Raul Rangel <rrangel@chromium.org> | 2022-09-02 16:26:41 +0000 |
| commit | 16528cd26f555732eef947b5219c3e7c85766d45 (patch) | |
| tree | 5e6dd97c94020256087df9f8e2938bc70ecf3c7f | |
| parent | fbde1a5880ae6bacebe97a6a9d9386da5e69bc19 (diff) | |
mb/google/skyrim: Remove elog_gsmi_cb_mainboard_log_wake_source
elog_gsmi_cb_mainboard_log_wake_source is called from SMI and causes
eSPI transactions. If the SMI interrupts an ongoing eSPI transaction
from the OS it will conflict and cause failures. Removing this call to
avoid conflicts. This can be re-enabled after refactoring
google_chromeec_get_mask to use ACPI MMIO.
This is a copy of CB:63280 but for skyrim.
BUG=b:227163985, b:243557044
TEST=suspend/resume skyrim and no longer see EC wake sources in elog.
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: Iac56840fe15101bc556d8cce9960f761c6ea7181
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67184
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jon Murphy <jpmurphy@google.com>
| -rw-r--r-- | src/mainboard/google/skyrim/variants/baseboard/smihandler.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/mainboard/google/skyrim/variants/baseboard/smihandler.c b/src/mainboard/google/skyrim/variants/baseboard/smihandler.c index ef26a421fc..dcc19f3623 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/smihandler.c +++ b/src/mainboard/google/skyrim/variants/baseboard/smihandler.c @@ -26,8 +26,3 @@ int mainboard_smi_apmc(u8 apmc) return 0; } - -void elog_gsmi_cb_mainboard_log_wake_source(void) -{ - google_chromeec_log_events(MAINBOARD_EC_LOG_EVENTS | MAINBOARD_EC_S0IX_WAKE_EVENTS); -} |