diff options
| author | Martin Roth <martinroth@google.com> | 2016-09-14 18:11:01 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2016-09-22 22:33:55 +0200 |
| commit | 0f671f6ee94822052395d36a0cb2552877d218cd (patch) | |
| tree | 924d20afa1ec0cef75b0b6efc59ce1b46d28841a | |
| parent | 66c2c1a2d4eed1aa4d3aad70b8790db5a4536beb (diff) | |
Build system: Remove IASL_WARNINGS_ARE_ERRORS option
All systems are building with IASL warnings as errors enabled.
Remove the option to disable it.
Remove the notification at the end of the build.
Change-Id: I5c6218c182fdf173b4026fd010d939a5fa36040e
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/16606
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
| -rw-r--r-- | Makefile.inc | 8 | ||||
| -rw-r--r-- | src/Kconfig | 13 |
2 files changed, 0 insertions, 21 deletions
diff --git a/Makefile.inc b/Makefile.inc index ffe6015af5..d6c747646f 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -238,11 +238,7 @@ cbfs-files-$(if $(2),$(2),y) += $(CONFIG_CBFS_PREFIX)/$(1).aml $(obj)/$(1).aml: $(src)/mainboard/$(MAINBOARDDIR)/$(1).asl $(obj)/config.h @printf " IASL $$(subst $(top)/,,$$(@))\n" $(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) $$(CPPFLAGS_ramstage) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-ramstage-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$@ -ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),y) cd $$(dir $$@); $(IASL) -we -p $$(notdir $$@) $$(notdir $$@) -else - cd $$(dir $$@); $(IASL) -p $$(notdir $$@) $$(notdir $$@) -endif if [ -z "$$$$($(IASL) -d $$@ 2>&1 | grep 'ACPI Warning')" ]; then echo " IASL $$@ disassembled correctly."; true; else echo "Error: Could not correctly disassemble $$@"; $(IASL) -d $$@; false; fi endef @@ -895,10 +891,6 @@ endif mv $@.tmp $@ @printf " CBFSPRINT $(subst $(obj)/,,$(@))\n\n" $(CBFSTOOL) $@ print -r $(subst $(spc),$(comma),$(all-regions)) -ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),) - @printf "\n***** WARNING: IASL warnings as errors is disabled! *****\n" - @printf "***** Please fix the ASL for this platform. *****\n\n" -endif cbfs-files-y += $(CONFIG_CBFS_PREFIX)/romstage $(CONFIG_CBFS_PREFIX)/romstage-file := $(objcbfs)/romstage.elf diff --git a/src/Kconfig b/src/Kconfig index a43a9796d0..f6c022e8be 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1146,19 +1146,6 @@ config WARNINGS_ARE_ERRORS bool default y -# TODO: Remove this when all platforms are fixed. -config IASL_WARNINGS_ARE_ERRORS - def_bool y - help - Select to Fail the build if a IASL generates a warning. - This will be defaulted to disabled for the platforms that - currently fail. This allows the REST of the platforms to - have this check enabled while we're working to get those - boards fixed. - - DO NOT ADD TO ANY ADDITIONAL PLATFORMS INSTEAD OF FIXING - THE ASL. - # The four POWER_BUTTON_DEFAULT_ENABLE, POWER_BUTTON_DEFAULT_DISABLE, # POWER_BUTTON_FORCE_ENABLE and POWER_BUTTON_FORCE_DISABLE options are # mutually exclusive. One of these options must be selected in the |