diff options
| author | Alex Thiessen <alex.thiessen.de+coreboot@gmail.com> | 2018-01-05 05:19:10 +0000 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2018-01-11 22:09:33 +0000 |
| commit | 6719862de80cec31a910ab1cc39fb7d3ba7b9a80 (patch) | |
| tree | e6dc75f3b35b455e803bb68e18d8f559258398e6 | |
| parent | 750ec9431470912124b899cbea2ed7f275af4647 (diff) | |
util/gitconfig: Refuse to commit on lint failure
After running `lint-stable` in the pre-commit hook, its result is
ignored. This behavior was introduced in commit b18f522b
(lint/gitconfig: Enable checkpatch.pl checking of commits) and it
doesn't seem intentional. This issue was also mentioned in the revert
discussion (https://review.coreboot.org/c/coreboot/+/17440).
Enable `errexit` mode of the shell so that the hook fails when an error
occurs in any of the tests. Also, enable `nounset` mode to catch typos
easier.
Change-Id: I749963167660ea6a1a04d40a14ad1113e82f0f86
Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com>
Reviewed-on: https://review.coreboot.org/23130
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
| -rwxr-xr-x | util/gitconfig/pre-commit | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit index ac0db4a238..0f1306288e 100755 --- a/util/gitconfig/pre-commit +++ b/util/gitconfig/pre-commit @@ -15,6 +15,9 @@ ## GNU General Public License for more details. ## +set -e # -o errexit +set -u # -o nounset + %MAKE% lint-stable PATCHDIFF=$(git diff --cached) |