From 6719862de80cec31a910ab1cc39fb7d3ba7b9a80 Mon Sep 17 00:00:00 2001 From: Alex Thiessen Date: Fri, 5 Jan 2018 05:19:10 +0000 Subject: util/gitconfig: Refuse to commit on lint failure After running `lint-stable` in the pre-commit hook, its result is ignored. This behavior was introduced in commit b18f522b (lint/gitconfig: Enable checkpatch.pl checking of commits) and it doesn't seem intentional. This issue was also mentioned in the revert discussion (https://review.coreboot.org/c/coreboot/+/17440). Enable `errexit` mode of the shell so that the hook fails when an error occurs in any of the tests. Also, enable `nounset` mode to catch typos easier. Change-Id: I749963167660ea6a1a04d40a14ad1113e82f0f86 Signed-off-by: Alex Thiessen Reviewed-on: https://review.coreboot.org/23130 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- util/gitconfig/pre-commit | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/gitconfig/pre-commit b/util/gitconfig/pre-commit index ac0db4a238..0f1306288e 100755 --- a/util/gitconfig/pre-commit +++ b/util/gitconfig/pre-commit @@ -15,6 +15,9 @@ ## GNU General Public License for more details. ## +set -e # -o errexit +set -u # -o nounset + %MAKE% lint-stable PATCHDIFF=$(git diff --cached) -- cgit v1.2.3