summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Singer <felixsinger@posteo.net>2024-06-28 00:08:17 +0200
committerFelix Singer <felixsinger@posteo.net>2024-06-28 22:11:31 +0000
commit0486f2b3bb53f8f470b8842eda794f929dfee92c (patch)
treeeb84d6fa3dd18cc80dfca2a9ab3953e3f7d9eaa0
parent8c1daf97519c64d4e0ac6c1ace3e54a2549a7612 (diff)
tgl mainboards: Drop disabled audio settings from dt
Configuring them to 0 is equal to not configuring them at all. So remove them to clean up a bit. Change-Id: I9a9eb370e8e9e8874ad8b4b8ac0f43d61c1a4b9b Signed-off-by: Felix Singer <felixsinger@posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83250 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/devicetree.cb7
-rw-r--r--src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb2
-rw-r--r--src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb2
3 files changed, 0 insertions, 11 deletions
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index 4fdc7b4839..8bf1c7dde9 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -213,13 +213,6 @@ chip soc/intel/tigerlake
# HD Audio
register "PchHdaDspEnable" = "1"
- register "PchHdaAudioLinkHdaEnable" = "0"
- register "PchHdaAudioLinkDmicEnable[0]" = "0"
- register "PchHdaAudioLinkDmicEnable[1]" = "0"
- register "PchHdaAudioLinkSspEnable[0]" = "0"
- register "PchHdaAudioLinkSspEnable[1]" = "0"
- register "PchHdaAudioLinkSndwEnable[0]" = "0"
- register "PchHdaAudioLinkSndwEnable[1]" = "0"
# TCSS USB3
register "UsbTcPortEn" = "0x3"
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
index 7c60f0c9c3..ecad52e60a 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
@@ -126,11 +126,9 @@ chip soc/intel/tigerlake
#HD Audio
register "PchHdaDspEnable" = "1"
- register "PchHdaAudioLinkHdaEnable" = "0"
register "PchHdaAudioLinkDmicEnable[0]" = "1"
register "PchHdaAudioLinkDmicEnable[1]" = "1"
register "PchHdaAudioLinkSspEnable[0]" = "1"
- register "PchHdaAudioLinkSspEnable[1]" = "0"
register "PchHdaAudioLinkSspEnable[2]" = "1"
register "PchHdaAudioLinkSndwEnable[0]" = "1"
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
index 03e9c2d982..4a523a7a1a 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
@@ -134,11 +134,9 @@ chip soc/intel/tigerlake
#HD Audio
register "PchHdaDspEnable" = "1"
- register "PchHdaAudioLinkHdaEnable" = "0"
register "PchHdaAudioLinkDmicEnable[0]" = "1"
register "PchHdaAudioLinkDmicEnable[1]" = "1"
register "PchHdaAudioLinkSspEnable[0]" = "1"
- register "PchHdaAudioLinkSspEnable[1]" = "0"
register "PchHdaAudioLinkSspEnable[2]" = "1"
register "PchHdaAudioLinkSndwEnable[0]" = "1"