From 0486f2b3bb53f8f470b8842eda794f929dfee92c Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Fri, 28 Jun 2024 00:08:17 +0200 Subject: tgl mainboards: Drop disabled audio settings from dt Configuring them to 0 is equal to not configuring them at all. So remove them to clean up a bit. Change-Id: I9a9eb370e8e9e8874ad8b4b8ac0f43d61c1a4b9b Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/83250 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/mainboard/google/volteer/variants/baseboard/devicetree.cb | 7 ------- src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb | 2 -- src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb | 2 -- 3 files changed, 11 deletions(-) diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 4fdc7b4839..8bf1c7dde9 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -213,13 +213,6 @@ chip soc/intel/tigerlake # HD Audio register "PchHdaDspEnable" = "1" - register "PchHdaAudioLinkHdaEnable" = "0" - register "PchHdaAudioLinkDmicEnable[0]" = "0" - register "PchHdaAudioLinkDmicEnable[1]" = "0" - register "PchHdaAudioLinkSspEnable[0]" = "0" - register "PchHdaAudioLinkSspEnable[1]" = "0" - register "PchHdaAudioLinkSndwEnable[0]" = "0" - register "PchHdaAudioLinkSndwEnable[1]" = "0" # TCSS USB3 register "UsbTcPortEn" = "0x3" diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index 7c60f0c9c3..ecad52e60a 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -126,11 +126,9 @@ chip soc/intel/tigerlake #HD Audio register "PchHdaDspEnable" = "1" - register "PchHdaAudioLinkHdaEnable" = "0" register "PchHdaAudioLinkDmicEnable[0]" = "1" register "PchHdaAudioLinkDmicEnable[1]" = "1" register "PchHdaAudioLinkSspEnable[0]" = "1" - register "PchHdaAudioLinkSspEnable[1]" = "0" register "PchHdaAudioLinkSspEnable[2]" = "1" register "PchHdaAudioLinkSndwEnable[0]" = "1" diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index 03e9c2d982..4a523a7a1a 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -134,11 +134,9 @@ chip soc/intel/tigerlake #HD Audio register "PchHdaDspEnable" = "1" - register "PchHdaAudioLinkHdaEnable" = "0" register "PchHdaAudioLinkDmicEnable[0]" = "1" register "PchHdaAudioLinkDmicEnable[1]" = "1" register "PchHdaAudioLinkSspEnable[0]" = "1" - register "PchHdaAudioLinkSspEnable[1]" = "0" register "PchHdaAudioLinkSspEnable[2]" = "1" register "PchHdaAudioLinkSndwEnable[0]" = "1" -- cgit v1.2.3