aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSean Rhodes <sean@starlabs.systems>2023-05-02 21:02:43 +0100
committerFelix Held <felix-coreboot@felixheld.de>2023-05-22 12:42:54 +0000
commitbfe2cd402d30e7eb7b82f3f4c7d096dcffe2c5b1 (patch)
treef70dfda0a63cc51e5a189de2ca7dc5562fda350c
parent9ab3a1fe4a1dace4dad7f1aebcfd2c623f9fbf0a (diff)
soc/intel/common: Add an error for missing ramtop CMOS entry
Show an error if an option table is used, and the ramtop entry is not defined on a platform that uses it. Signed-off-by: Sean Rhodes <sean@starlabs.systems> Change-Id: Ie48f0766b29be8e1fb0c1f71c4b2ce6ed20e6207 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74920 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
-rw-r--r--src/soc/intel/common/basecode/ramtop/ramtop.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/soc/intel/common/basecode/ramtop/ramtop.c b/src/soc/intel/common/basecode/ramtop/ramtop.c
index f6aa4eadd4..83af44dbaa 100644
--- a/src/soc/intel/common/basecode/ramtop/ramtop.c
+++ b/src/soc/intel/common/basecode/ramtop/ramtop.c
@@ -19,6 +19,10 @@
#if CONFIG(USE_OPTION_TABLE)
#include "option_table.h"
+#ifndef CMOS_VSTART_ramtop
+#error "The `ramtop` CMOS entry is missing, please add it to your cmos.layout."
+#endif
+
#if CMOS_VSTART_ramtop % 8 != 0
#error "The `ramtop` CMOS entry needs to be byte aligned, check your cmos.layout."
#endif // CMOS_VSTART_ramtop % 8 != 0