From bfe2cd402d30e7eb7b82f3f4c7d096dcffe2c5b1 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 2 May 2023 21:02:43 +0100 Subject: soc/intel/common: Add an error for missing ramtop CMOS entry Show an error if an option table is used, and the ramtop entry is not defined on a platform that uses it. Signed-off-by: Sean Rhodes Change-Id: Ie48f0766b29be8e1fb0c1f71c4b2ce6ed20e6207 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74920 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Lean Sheng Tan --- src/soc/intel/common/basecode/ramtop/ramtop.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/soc/intel/common/basecode/ramtop/ramtop.c b/src/soc/intel/common/basecode/ramtop/ramtop.c index f6aa4eadd4..83af44dbaa 100644 --- a/src/soc/intel/common/basecode/ramtop/ramtop.c +++ b/src/soc/intel/common/basecode/ramtop/ramtop.c @@ -19,6 +19,10 @@ #if CONFIG(USE_OPTION_TABLE) #include "option_table.h" +#ifndef CMOS_VSTART_ramtop +#error "The `ramtop` CMOS entry is missing, please add it to your cmos.layout." +#endif + #if CMOS_VSTART_ramtop % 8 != 0 #error "The `ramtop` CMOS entry needs to be byte aligned, check your cmos.layout." #endif // CMOS_VSTART_ramtop % 8 != 0 -- cgit v1.2.3