summaryrefslogtreecommitdiff
path: root/3rdparty
diff options
context:
space:
mode:
authorRaul E Rangel <rrangel@chromium.org>2021-12-06 14:54:55 -0700
committerFelix Held <felix-coreboot@felixheld.de>2021-12-08 20:25:33 +0000
commit59d64f06be8eb5f80acfb0b53e7accaf05c1bec8 (patch)
treedf57fe50cd1b096a9dca70b4b8e3166ef4137f72 /3rdparty
parent105495f37e0a5e063b4ca414e84f344b13cc28d4 (diff)
soc/amd/{cezanne,picasso,stoney,common}: Don't clear PM1 on resume
According to https://uefi.org/specs/ACPI/6.4/04_ACPI_Hardware_Specification/ACPI_Hardware_Specification.html#pm1-event-grouping > For ACPI/legacy systems, when transitioning from the legacy to the G0 > working state this register is cleared by platform firmware prior to > setting the SCI_EN bit (and thus passing control to OSPM). For ACPI > only platforms (where SCI_EN is always set), when transitioning from > either the mechanical off (G3) or soft-off state to the G0 working > state this register is cleared prior to entering the G0 working state. This means we don't want to clear the PM1 register on resume. By clearing it the linux kernel can't correctly increment the wake count when the power button is pressed. The AMD platforms implement the _SWS ACPI methods, but the linux kernel doesn't actually use these methods. BUG=b:172021431 TEST=suspend zork and push power button and verify power button wake_count increments. Verified other wake sources still work. Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: Iaa886540d90f4751d14837c1485ef50ceca48561 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59929 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to '3rdparty')
0 files changed, 0 insertions, 0 deletions