summaryrefslogtreecommitdiff
path: root/.gitreview
diff options
context:
space:
mode:
authorWerner Zeh <werner.zeh@siemens.com>2021-10-21 15:54:23 +0200
committerFelix Held <felix-coreboot@felixheld.de>2021-10-29 14:38:09 +0000
commit69dcc1e5154260359c516d85ab728a2094aa600b (patch)
treee8220039209527a5a8c80ca859437ff96dca01cc /.gitreview
parenteb0404e8bf57779036a3867c1a7797c9f7ef93c3 (diff)
soc/intel/apollolake: Fix BUG-message when checking for XDCI device
The current check for XDCI enabled uses a static device path to an internal PCI device at a very late point in the boot flow. At this time the devicetree has been processed and disabled devices have been already removed. If this device (00:15.1, XDCI) is disabled in devicetree this will trigger the message 'BUG: check_xdci_enable requests hidden 00:15.1' in the log. This looks weird and is wrong since it is not a bug to disable this device when it is not needed. To avoid this look up the devicetree by a tree walk instead of using a static value for the devicetree. Change-Id: If193be724299c4017e7e10142fac8db9fac44383 Signed-off-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/58524 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@mailbox.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to '.gitreview')
0 files changed, 0 insertions, 0 deletions