summaryrefslogtreecommitdiff
path: root/.gitreview
diff options
context:
space:
mode:
authorzbao <fishbaozi@gmail.com>2015-11-05 14:35:57 +0800
committerZheng Bao <zheng.bao@amd.com>2015-11-20 05:36:48 +0100
commit37450ff5343ffa3326a3f23a8ae7448d48e14e3c (patch)
treecd973e287cf98b752b6052c888bf6ef48f88e770 /.gitreview
parentf730e44baaf061e2ab8ea4e21b5b0d60bc681dc3 (diff)
cbfstool: Fix build error with clang when comparing enum
If HOSTCC=clang, the -Wtautological-constant-out-of-range-compare is set automaticaaly. That assume the value of type enum is in the defined range. Then testing if a type enum is out of range causes build error. Error: coreboot/util/cbfstool/cbfs_image.c:1387:16: error: comparison of constant 4 with expression of type 'enum vb2_hash_algorithm' is always false [-Werror,-Wtautological-constant-out-of-range-compare] if (hash_type >= CBFS_NUM_SUPPORTED_HASHES) ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. clang version: FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512 Target: x86_64-unknown-freebsd10.2 Thread model: posix Change-Id: I3e1722bf6f9553793a9f0c7f4e790706b6938522 Signed-off-by: zbao <fishbaozi@gmail.com> Reviewed-on: http://review.coreboot.org/12330 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to '.gitreview')
0 files changed, 0 insertions, 0 deletions