diff options
Diffstat (limited to 'util')
-rw-r--r-- | util/autoport/readme.md | 20 | ||||
-rwxr-xr-x | util/crossgcc/buildgcc | 8 | ||||
-rw-r--r-- | util/intelmetool/me.h | 44 | ||||
-rw-r--r-- | util/romcc/romcc.c | 6 | ||||
-rw-r--r-- | util/vgabios/device.c | 7 | ||||
-rw-r--r-- | util/vgabios/testbios.c | 6 |
6 files changed, 46 insertions, 45 deletions
diff --git a/util/autoport/readme.md b/util/autoport/readme.md index 21174b03c9..67a2c56994 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -88,16 +88,16 @@ up in SPD. Under Linux you can see present SPD addresses with following commands phcoder@sid:~/coreboot/util/autoport$ sudo modprobe i2c-dev phcoder@sid:~/coreboot/util/autoport$ sudo i2cdetect -l - i2c-0 i2c i915 gmbus ssc I2C adapter - i2c-1 i2c i915 gmbus vga I2C adapter - i2c-2 i2c i915 gmbus panel I2C adapter - i2c-3 i2c i915 gmbus dpc I2C adapter - i2c-4 i2c i915 gmbus dpb I2C adapter - i2c-5 i2c i915 gmbus dpd I2C adapter - i2c-6 i2c DPDDC-B I2C adapter - i2c-7 i2c DPDDC-C I2C adapter - i2c-8 i2c DPDDC-D I2C adapter - i2c-9 smbus SMBus I801 adapter at 0400 SMBus adapter + i2c-0 i2c i915 gmbus ssc I2C adapter + i2c-1 i2c i915 gmbus vga I2C adapter + i2c-2 i2c i915 gmbus panel I2C adapter + i2c-3 i2c i915 gmbus dpc I2C adapter + i2c-4 i2c i915 gmbus dpb I2C adapter + i2c-5 i2c i915 gmbus dpd I2C adapter + i2c-6 i2c DPDDC-B I2C adapter + i2c-7 i2c DPDDC-C I2C adapter + i2c-8 i2c DPDDC-D I2C adapter + i2c-9 smbus SMBus I801 adapter at 0400 SMBus adapter phcoder@sid:~/coreboot/util/autoport$ sudo i2cdetect 9 WARNING! This program can confuse your I2C bus, cause data loss and worse! I will probe file /dev/i2c-9. diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index addc61f186..cd8a091989 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -1191,7 +1191,7 @@ export PATH=$DESTDIR$TARGETDIR/bin:$PATH # Download, unpack, patch and build all packages -printf "Downloading and verifing tarballs ... \n" +printf "Downloading and verifing tarballs ...\n" mkdir -p tarballs for P in $PACKAGES; do download "$P" || exit "$?" @@ -1199,21 +1199,21 @@ for P in $PACKAGES; do done printf "Downloaded tarballs ... ${green}ok${NC}\n" -printf "Unpacking and patching ... \n" +printf "Unpacking and patching ...\n" for P in $PACKAGES; do unpack_and_patch $P || exit 1 done printf "Unpacked and patched ... ${green}ok${NC}\n" if [ -n "$BOOTSTRAPONLY" ]; then - printf "Building bootstrap compiler only ... \n" + printf "Building bootstrap compiler only ...\n" for pkg in GMP MPFR MPC GCC; do build_for_host $pkg done exit 0 fi -printf "Building packages ... \n" +printf "Building packages ...\n" for package in $PACKAGES; do build $package done diff --git a/util/intelmetool/me.h b/util/intelmetool/me.h index ff69d7e7a5..dfd5cbb92b 100644 --- a/util/intelmetool/me.h +++ b/util/intelmetool/me.h @@ -76,7 +76,7 @@ struct me_hfs { uint32_t boot_options_present: 1; uint32_t ack_data: 3; uint32_t bios_msg_ack: 4; -} __attribute__ ((packed)); +} __attribute__((packed)); #define PCI_ME_UMA 0x44 @@ -86,7 +86,7 @@ struct me_uma { uint32_t valid: 1; uint32_t reserved_0: 14; uint32_t set_to_one: 1; -} __attribute__ ((packed)); +} __attribute__((packed)); #define PCI_ME_H_GS 0x4c #define ME_INIT_DONE 1 @@ -99,7 +99,7 @@ struct me_did { uint32_t reserved: 8; uint32_t status: 4; uint32_t init_done: 4; -} __attribute__ ((packed)); +} __attribute__((packed)); #define PCI_ME_GMES 0x48 #define ME_GMES_PHASE_ROM 0 @@ -125,7 +125,7 @@ struct me_gmes { uint32_t current_state: 8; uint32_t current_pmevent: 4; uint32_t progress_code: 4; -} __attribute__ ((packed)); +} __attribute__((packed)); #define PCI_ME_HERES 0xbc #define PCI_ME_EXT_SHA1 0x00 @@ -137,14 +137,14 @@ struct me_heres { uint32_t reserved: 26; uint32_t extend_feature_present: 1; uint32_t extend_reg_valid: 1; -} __attribute__ ((packed)); +} __attribute__((packed)); struct me_thermal_reporting { uint32_t polling_timeout: 8; uint32_t smbus_ec_msglen: 8; uint32_t smbus_ec_msgpec: 8; uint32_t dimmnumber: 8; -} __attribute__ ((packed)); +} __attribute__((packed)); /* * Management Engine MEI registers @@ -165,7 +165,7 @@ struct mei_csr { uint32_t buffer_read_ptr: 8; uint32_t buffer_write_ptr: 8; uint32_t buffer_depth: 8; -} __attribute__ ((packed)); +} __attribute__((packed)); #define MEI_ADDRESS_HBM 0x00 #define MEI_ADDRESS_CORE_WD 0x01 @@ -187,7 +187,7 @@ struct mei_header { uint32_t length: 9; uint32_t reserved: 6; uint32_t is_complete: 1; -} __attribute__ ((packed)); +} __attribute__((packed)); #define MKHI_GROUP_ID_CBM 0x00 #define MKHI_GROUP_ID_PM 0x01 @@ -231,7 +231,7 @@ struct mkhi_header { uint32_t is_response: 1; uint32_t reserved: 8; uint32_t result: 8; -} __attribute__ ((packed)); +} __attribute__((packed)); struct me_fw_version { uint16_t code_minor; @@ -246,7 +246,7 @@ struct me_fw_version { uint16_t fitcmajor; uint16_t fitcbuildno; uint16_t fitchotfix; -} __attribute__ ((packed)); +} __attribute__((packed)); #define HECI_EOP_STATUS_SUCCESS 0x0 @@ -261,7 +261,7 @@ struct me_fw_version { struct me_global_reset { uint8_t request_origin; uint8_t reset_type; -} __attribute__ ((packed)); +} __attribute__((packed)); typedef enum { ME_NORMAL_BIOS_PATH, @@ -277,7 +277,7 @@ typedef struct { uint32_t minor_version : 16; uint32_t hotfix_version : 16; uint32_t build_version : 16; -} __attribute__ ((packed)) mbp_fw_version_name; +} __attribute__((packed)) mbp_fw_version_name; typedef struct { uint8_t num_icc_profiles; @@ -285,7 +285,7 @@ typedef struct { uint8_t icc_profile_index; uint8_t reserved; uint32_t register_lock_mask[3]; -} __attribute__ ((packed)) mbp_icc_profile; +} __attribute__((packed)) mbp_icc_profile; typedef struct { uint32_t full_net : 1; @@ -308,7 +308,7 @@ typedef struct { uint32_t reserved_4 : 1; uint32_t wlan : 1; uint32_t reserved_5 : 8; -} __attribute__ ((packed)) mefwcaps_sku; +} __attribute__((packed)) mefwcaps_sku; typedef struct { uint16_t lock_state : 1; @@ -319,13 +319,13 @@ typedef struct { uint16_t wwan3gpresent : 1; uint16_t wwan3goob : 1; uint16_t reserved : 9; -} __attribute__ ((packed)) tdt_state_flag; +} __attribute__((packed)) tdt_state_flag; typedef struct { uint8_t state; uint8_t last_theft_trigger; tdt_state_flag flags; -} __attribute__ ((packed)) tdt_state_info; +} __attribute__((packed)) tdt_state_info; typedef struct { uint32_t platform_target_usage_type : 4; @@ -335,7 +335,7 @@ typedef struct { uint32_t intel_me_fw_image_type : 4; uint32_t platform_brand : 4; uint32_t reserved_1 : 16; -} __attribute__ ((packed)) platform_type_rule_data; +} __attribute__((packed)) platform_type_rule_data; typedef struct { mefwcaps_sku fw_capabilities; @@ -346,7 +346,7 @@ typedef struct { uint16_t device_id; uint16_t fuse_test_flags; uint32_t umchid[4]; -} __attribute__ ((packed)) mbp_rom_bist_data; +} __attribute__((packed)) mbp_rom_bist_data; typedef struct { uint32_t key[8]; @@ -372,28 +372,28 @@ typedef struct { uint32_t mbp_size : 8; uint32_t num_entries : 8; uint32_t rsvd : 16; -} __attribute__ ((packed)) mbp_header; +} __attribute__((packed)) mbp_header; typedef struct { uint32_t app_id : 8; uint32_t item_id : 8; uint32_t length : 8; uint32_t rsvd : 8; -} __attribute__ ((packed)) mbp_item_header; +} __attribute__((packed)) mbp_item_header; struct me_fwcaps { uint32_t id; uint8_t length; mefwcaps_sku caps_sku; uint8_t reserved[3]; -} __attribute__ ((packed)); +} __attribute__((packed)); struct me_debug_mem { uint32_t debug_phys; uint32_t debug_size; uint32_t me_phys; uint32_t me_size; -} __attribute__ ((packed)); +} __attribute__((packed)); void intel_me_status(uint32_t hfs, uint32_t gmes); void mkhi_thermal(void); diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index 9a7d1a2ff6..ebea26ff79 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -9199,7 +9199,7 @@ static void decompose_compound_types(struct compile_state *state) } #if DEBUG_DECOMPOSE_HIRES - fprintf(fp, "decompose next: %p \n", next); + fprintf(fp, "decompose next: %p\n", next); fflush(fp); fprintf(fp, "next->op: %d %s\n", next->op, tops(next->op)); @@ -14284,7 +14284,7 @@ static void compute_closure_variables(struct compile_state *state, #if DEBUG_EXPLICIT_CLOSURES /* Print out the variables to be enclosed */ loc(state->dbgout, state, fcall); - fprintf(state->dbgout, "Alive: \n"); + fprintf(state->dbgout, "Alive:\n"); for(set = *enclose; set; set = set->next) { display_triple(state->dbgout, set->member); } @@ -25048,7 +25048,7 @@ static void usage(void) fprintf(fp, "\nUsage: romcc [options] <source>.c\n" "Compile a C source file generating a binary that does not implicilty use RAM\n" - "Options: \n" + "Options:\n" "-o <output file name>\n" "-f<option> Specify a generic compiler option\n" "-m<option> Specify a arch dependent option\n" diff --git a/util/vgabios/device.c b/util/vgabios/device.c index 3526e24716..ecd2481a56 100644 --- a/util/vgabios/device.c +++ b/util/vgabios/device.c @@ -80,7 +80,8 @@ biosemu_dev_get_addr_info(void) taa_index++; /* legacy ranges if its a VGA card... */ if ((bios_device.dev->class & 0xFF0000) == 0x030000) { - DEBUG_PRINTF("%s: VGA device found, adding legacy resources... \n", __func__); + DEBUG_PRINTF("%s: VGA device found, adding legacy resources..." + "\n", __func__); /* I/O 0x3B0-0x3BB */ translate_address_array[taa_index].info = IORESOURCE_FIXED | IORESOURCE_IO; translate_address_array[taa_index].bus = bus; @@ -116,7 +117,7 @@ biosemu_dev_get_addr_info(void) taa_last_entry = taa_index - 1; #if CONFIG_X86EMU_DEBUG //dump translate_address_array - printf("translate_address_array: \n"); + printf("translate_address_array:\n"); translate_address_t ta; int i; for (i = 0; i <= taa_last_entry; i++) { @@ -201,7 +202,7 @@ biosemu_dev_get_addr_info(void) taa_last_entry = taa_index - 1; #if CONFIG_X86EMU_DEBUG //dump translate_address_array - printf("translate_address_array: \n"); + printf("translate_address_array:\n"); translate_address_t ta; for (i = 0; i <= taa_last_entry; i++) { ta = translate_address_array[i]; diff --git a/util/vgabios/testbios.c b/util/vgabios/testbios.c index aedeb1d217..de537b8fcd 100644 --- a/util/vgabios/testbios.c +++ b/util/vgabios/testbios.c @@ -116,8 +116,8 @@ int printk(int msg_level, const char *fmt, ...) static void usage(char *name) { printf - ("Usage: %s [-c codesegment] [-s size] [-b base] [-i ip] [-t] <filename> ... \n", - name); + ("Usage: %s [-c codesegment] [-s size] [-b base] [-i ip] [-t] " + "<filename> ...\n", name); } /* main entry into YABEL biosemu, arguments are: @@ -218,7 +218,7 @@ int main(int argc, char **argv) debugflag = strtol(optarg, 0, 0); break; default: - printf("Unknown option \n"); + printf("Unknown option\n"); usage(argv[0]); return 1; } |