summaryrefslogtreecommitdiff
path: root/src/soc
diff options
context:
space:
mode:
Diffstat (limited to 'src/soc')
-rw-r--r--src/soc/nvidia/tegra/displayport.h2
-rw-r--r--src/soc/nvidia/tegra/software_i2c.c4
-rw-r--r--src/soc/nvidia/tegra124/bootblock.c4
-rw-r--r--src/soc/nvidia/tegra124/cache.c2
-rw-r--r--src/soc/nvidia/tegra124/cbfs.c3
-rw-r--r--src/soc/nvidia/tegra124/cbmem.c2
-rw-r--r--src/soc/nvidia/tegra124/chip.h2
-rw-r--r--src/soc/nvidia/tegra124/clock.c14
-rw-r--r--src/soc/nvidia/tegra124/display.c25
-rw-r--r--src/soc/nvidia/tegra124/dma.c10
-rw-r--r--src/soc/nvidia/tegra124/dp.c11
-rw-r--r--src/soc/nvidia/tegra124/include/soc/cache.h (renamed from src/soc/nvidia/tegra124/cache.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/clk_rst.h (renamed from src/soc/nvidia/tegra124/clk_rst.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/clock.h2
-rw-r--r--src/soc/nvidia/tegra124/include/soc/dma.h (renamed from src/soc/nvidia/tegra124/dma.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/early_configs.h (renamed from src/soc/nvidia/tegra124/early_configs.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/emc.h (renamed from src/soc/nvidia/tegra124/emc.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/flow.h (renamed from src/soc/nvidia/tegra124/flow.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/gpio.h (renamed from src/soc/nvidia/tegra124/gpio.h)3
-rw-r--r--src/soc/nvidia/tegra124/include/soc/maincpu.h (renamed from src/soc/nvidia/tegra124/maincpu.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/mc.h (renamed from src/soc/nvidia/tegra124/mc.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/memlayout.ld (renamed from src/soc/nvidia/tegra124/memlayout.ld)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/pingroup.h (renamed from src/soc/nvidia/tegra124/pingroup.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/pinmux.h (renamed from src/soc/nvidia/tegra124/pinmux.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/pmc.h (renamed from src/soc/nvidia/tegra124/pmc.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/power.h (renamed from src/soc/nvidia/tegra124/power.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/sdram.h (renamed from src/soc/nvidia/tegra124/sdram.h)2
-rw-r--r--src/soc/nvidia/tegra124/include/soc/sdram_param.h (renamed from src/soc/nvidia/tegra124/sdram_param.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/sor.h (renamed from src/soc/nvidia/tegra124/sor.h)0
-rw-r--r--src/soc/nvidia/tegra124/include/soc/spi.h (renamed from src/soc/nvidia/tegra124/spi.h)3
-rw-r--r--src/soc/nvidia/tegra124/include/soc/sysctr.h (renamed from src/soc/nvidia/tegra124/sysctr.h)0
-rw-r--r--src/soc/nvidia/tegra124/power.c7
-rw-r--r--src/soc/nvidia/tegra124/sdram.c8
-rw-r--r--src/soc/nvidia/tegra124/sdram_lp0.c9
-rw-r--r--src/soc/nvidia/tegra124/soc.c7
-rw-r--r--src/soc/nvidia/tegra124/sor.c28
-rw-r--r--src/soc/nvidia/tegra124/spi.c14
-rw-r--r--src/soc/nvidia/tegra124/uart.c2
-rw-r--r--src/soc/nvidia/tegra124/verstage.c4
39 files changed, 83 insertions, 85 deletions
diff --git a/src/soc/nvidia/tegra/displayport.h b/src/soc/nvidia/tegra/displayport.h
index 5bf8423d11..b7face5d4e 100644
--- a/src/soc/nvidia/tegra/displayport.h
+++ b/src/soc/nvidia/tegra/displayport.h
@@ -17,6 +17,8 @@
#ifndef __SOC_NVIDIA_TEGRA_DISPLAYPORT_H__
#define __SOC_NVIDIA_TEGRA_DISPLAYPORT_H__
+#include <soc/sor.h>
+
/* things we can't get rid of just yet. */
#define DPAUX_INTR_EN_AUX (0x1)
#define DPAUX_INTR_AUX (0x5)
diff --git a/src/soc/nvidia/tegra/software_i2c.c b/src/soc/nvidia/tegra/software_i2c.c
index b50fb4f654..35fc1af3cc 100644
--- a/src/soc/nvidia/tegra/software_i2c.c
+++ b/src/soc/nvidia/tegra/software_i2c.c
@@ -18,8 +18,8 @@
*/
#include <device/i2c.h>
-#include <soc/nvidia/tegra124/gpio.h>
-#include <soc/nvidia/tegra124/pinmux.h>
+#include <soc/gpio.h>
+#include <soc/pinmux.h>
#include "i2c.h"
diff --git a/src/soc/nvidia/tegra124/bootblock.c b/src/soc/nvidia/tegra124/bootblock.c
index 1ccc394be2..7318ad66b9 100644
--- a/src/soc/nvidia/tegra124/bootblock.c
+++ b/src/soc/nvidia/tegra124/bootblock.c
@@ -25,9 +25,9 @@
#include <program_loading.h>
#include <soc/clock.h>
#include <soc/nvidia/tegra/apbmisc.h>
+#include <soc/pinmux.h>
+#include <soc/power.h>
#include <vendorcode/google/chromeos/chromeos.h>
-#include "pinmux.h"
-#include "power.h"
static void run_next_stage(void *entry)
{
diff --git a/src/soc/nvidia/tegra124/cache.c b/src/soc/nvidia/tegra124/cache.c
index 55e625478a..a925eafa63 100644
--- a/src/soc/nvidia/tegra124/cache.c
+++ b/src/soc/nvidia/tegra124/cache.c
@@ -18,8 +18,8 @@
*/
#include <arch/cache.h>
+#include <soc/cache.h>
#include <stdint.h>
-#include "cache.h"
enum {
L2CTLR_ECC_PARITY = 0x1 << 21,
diff --git a/src/soc/nvidia/tegra124/cbfs.c b/src/soc/nvidia/tegra124/cbfs.c
index d56050d04c..33a7258feb 100644
--- a/src/soc/nvidia/tegra124/cbfs.c
+++ b/src/soc/nvidia/tegra124/cbfs.c
@@ -19,10 +19,9 @@
#include <cbfs.h> /* This driver serves as a CBFS media source. */
+#include <soc/spi.h>
#include <symbols.h>
-#include "spi.h"
-
int init_default_cbfs_media(struct cbfs_media *media)
{
return initialize_tegra_spi_cbfs_media(media,
diff --git a/src/soc/nvidia/tegra124/cbmem.c b/src/soc/nvidia/tegra124/cbmem.c
index 9a754a0fea..fcc19da350 100644
--- a/src/soc/nvidia/tegra124/cbmem.c
+++ b/src/soc/nvidia/tegra124/cbmem.c
@@ -19,7 +19,7 @@
#include <cbmem.h>
#include <soc/display.h>
-#include <soc/nvidia/tegra124/sdram.h>
+#include <soc/sdram.h>
void *cbmem_top(void)
{
diff --git a/src/soc/nvidia/tegra124/chip.h b/src/soc/nvidia/tegra124/chip.h
index 08e96ab809..c3652a182a 100644
--- a/src/soc/nvidia/tegra124/chip.h
+++ b/src/soc/nvidia/tegra124/chip.h
@@ -21,7 +21,7 @@
#define __SOC_NVIDIA_TEGRA124_CHIP_H__
#include <arch/cache.h>
#include <soc/addressmap.h>
-#include "gpio.h"
+#include <soc/gpio.h>
#define EFAULT 1
#define EINVAL 2
diff --git a/src/soc/nvidia/tegra124/clock.c b/src/soc/nvidia/tegra124/clock.c
index f5043af3cd..225a764431 100644
--- a/src/soc/nvidia/tegra124/clock.c
+++ b/src/soc/nvidia/tegra124/clock.c
@@ -14,19 +14,19 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
+#include <arch/clock.h>
+#include <arch/io.h>
#include <console/console.h>
#include <delay.h>
-#include <arch/io.h>
#include <soc/addressmap.h>
+#include <soc/clk_rst.h>
#include <soc/clock.h>
+#include <soc/flow.h>
+#include <soc/maincpu.h>
+#include <soc/pmc.h>
+#include <soc/sysctr.h>
#include <stdlib.h>
#include <symbols.h>
-#include <arch/clock.h>
-#include "clk_rst.h"
-#include "flow.h"
-#include "maincpu.h"
-#include "pmc.h"
-#include "sysctr.h"
static struct clk_rst_ctlr *clk_rst = (void *)TEGRA_CLK_RST_BASE;
static struct flow_ctlr *flow = (void *)TEGRA_FLOW_BASE;
diff --git a/src/soc/nvidia/tegra124/display.c b/src/soc/nvidia/tegra124/display.c
index 6f6790d56e..71fff1c93e 100644
--- a/src/soc/nvidia/tegra124/display.c
+++ b/src/soc/nvidia/tegra124/display.c
@@ -17,26 +17,27 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
-#include <console/console.h>
#include <arch/io.h>
-#include <stdint.h>
-#include <lib.h>
-#include <stdlib.h>
-#include <delay.h>
-#include <soc/addressmap.h>
-#include <device/device.h>
-#include <stdlib.h>
-#include <string.h>
-#include <cpu/cpu.h>
#include <boot/tables.h>
#include <cbmem.h>
+#include <console/console.h>
+#include <cpu/cpu.h>
+#include <delay.h>
+#include <device/device.h>
#include <edid.h>
+#include <lib.h>
+#include <soc/addressmap.h>
#include <soc/clock.h>
+#include <soc/display.h>
+#include <soc/sdram.h>
#include <soc/nvidia/tegra/dc.h>
#include <soc/nvidia/tegra/pwm.h>
-#include <soc/nvidia/tegra124/sdram.h>
+#include <stdint.h>
+#include <stdlib.h>
+#include <stdlib.h>
+#include <string.h>
+
#include "chip.h"
-#include <soc/display.h>
struct tegra_dc dc_data;
diff --git a/src/soc/nvidia/tegra124/dma.c b/src/soc/nvidia/tegra124/dma.c
index aadda80a6c..37375fd797 100644
--- a/src/soc/nvidia/tegra124/dma.c
+++ b/src/soc/nvidia/tegra124/dma.c
@@ -16,15 +16,13 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
+#include <arch/io.h>
+#include <console/console.h>
#include <inttypes.h>
+#include <soc/addressmap.h>
+#include <soc/dma.h>
#include <stddef.h>
#include <stdlib.h>
-#include <console/console.h>
-
-#include <arch/io.h>
-#include <soc/addressmap.h>
-
-#include "dma.h"
struct apb_dma * const apb_dma = (struct apb_dma *)TEGRA_APB_DMA_BASE;
diff --git a/src/soc/nvidia/tegra124/dp.c b/src/soc/nvidia/tegra124/dp.c
index 35a5c73036..b3dab75349 100644
--- a/src/soc/nvidia/tegra124/dp.c
+++ b/src/soc/nvidia/tegra124/dp.c
@@ -17,18 +17,19 @@
#include <arch/io.h>
#include <console/console.h>
+#include <delay.h>
#include <device/device.h>
#include <device/i2c.h>
#include <edid.h>
-#include <stdlib.h>
-#include <string.h>
-#include <delay.h>
#include <soc/addressmap.h>
#include <soc/nvidia/tegra/i2c.h>
#include <soc/nvidia/tegra/dc.h>
-#include "chip.h"
-#include "sor.h"
#include <soc/nvidia/tegra/displayport.h>
+#include <soc/sor.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "chip.h"
enum {
DP_LT_SUCCESS = 0,
diff --git a/src/soc/nvidia/tegra124/cache.h b/src/soc/nvidia/tegra124/include/soc/cache.h
index 3723cd7650..3723cd7650 100644
--- a/src/soc/nvidia/tegra124/cache.h
+++ b/src/soc/nvidia/tegra124/include/soc/cache.h
diff --git a/src/soc/nvidia/tegra124/clk_rst.h b/src/soc/nvidia/tegra124/include/soc/clk_rst.h
index d2249f7669..d2249f7669 100644
--- a/src/soc/nvidia/tegra124/clk_rst.h
+++ b/src/soc/nvidia/tegra124/include/soc/clk_rst.h
diff --git a/src/soc/nvidia/tegra124/include/soc/clock.h b/src/soc/nvidia/tegra124/include/soc/clock.h
index 82b2ad8100..3133d0f76a 100644
--- a/src/soc/nvidia/tegra124/include/soc/clock.h
+++ b/src/soc/nvidia/tegra124/include/soc/clock.h
@@ -21,7 +21,7 @@
#include <arch/hlt.h>
#include <arch/io.h>
#include <console/console.h>
-#include <soc/nvidia/tegra124/clk_rst.h>
+#include <soc/clk_rst.h>
#include <stdint.h>
#include <stdlib.h>
diff --git a/src/soc/nvidia/tegra124/dma.h b/src/soc/nvidia/tegra124/include/soc/dma.h
index e37bf743ad..e37bf743ad 100644
--- a/src/soc/nvidia/tegra124/dma.h
+++ b/src/soc/nvidia/tegra124/include/soc/dma.h
diff --git a/src/soc/nvidia/tegra124/early_configs.h b/src/soc/nvidia/tegra124/include/soc/early_configs.h
index 69511d2765..69511d2765 100644
--- a/src/soc/nvidia/tegra124/early_configs.h
+++ b/src/soc/nvidia/tegra124/include/soc/early_configs.h
diff --git a/src/soc/nvidia/tegra124/emc.h b/src/soc/nvidia/tegra124/include/soc/emc.h
index f9d415bcef..f9d415bcef 100644
--- a/src/soc/nvidia/tegra124/emc.h
+++ b/src/soc/nvidia/tegra124/include/soc/emc.h
diff --git a/src/soc/nvidia/tegra124/flow.h b/src/soc/nvidia/tegra124/include/soc/flow.h
index 416681ac8f..416681ac8f 100644
--- a/src/soc/nvidia/tegra124/flow.h
+++ b/src/soc/nvidia/tegra124/include/soc/flow.h
diff --git a/src/soc/nvidia/tegra124/gpio.h b/src/soc/nvidia/tegra124/include/soc/gpio.h
index f7d1c3006a..34de5b93df 100644
--- a/src/soc/nvidia/tegra124/gpio.h
+++ b/src/soc/nvidia/tegra124/include/soc/gpio.h
@@ -21,10 +21,9 @@
#define __SOC_NVIDIA_TEGRA124_GPIO_H__
#include <soc/nvidia/tegra/gpio.h>
+#include <soc/pinmux.h> /* for pinmux constants in GPIO macro */
#include <stdint.h>
-#include "pinmux.h" /* for pinmux constants in GPIO macro */
-
/* GPIO index constants. */
#define GPIO_PORT_CONSTANTS(port) \
diff --git a/src/soc/nvidia/tegra124/maincpu.h b/src/soc/nvidia/tegra124/include/soc/maincpu.h
index 1d5a907a80..1d5a907a80 100644
--- a/src/soc/nvidia/tegra124/maincpu.h
+++ b/src/soc/nvidia/tegra124/include/soc/maincpu.h
diff --git a/src/soc/nvidia/tegra124/mc.h b/src/soc/nvidia/tegra124/include/soc/mc.h
index 567b32a226..567b32a226 100644
--- a/src/soc/nvidia/tegra124/mc.h
+++ b/src/soc/nvidia/tegra124/include/soc/mc.h
diff --git a/src/soc/nvidia/tegra124/memlayout.ld b/src/soc/nvidia/tegra124/include/soc/memlayout.ld
index 0d9e772d41..0d9e772d41 100644
--- a/src/soc/nvidia/tegra124/memlayout.ld
+++ b/src/soc/nvidia/tegra124/include/soc/memlayout.ld
diff --git a/src/soc/nvidia/tegra124/pingroup.h b/src/soc/nvidia/tegra124/include/soc/pingroup.h
index ed9557b1ba..ed9557b1ba 100644
--- a/src/soc/nvidia/tegra124/pingroup.h
+++ b/src/soc/nvidia/tegra124/include/soc/pingroup.h
diff --git a/src/soc/nvidia/tegra124/pinmux.h b/src/soc/nvidia/tegra124/include/soc/pinmux.h
index c79732b7e2..c79732b7e2 100644
--- a/src/soc/nvidia/tegra124/pinmux.h
+++ b/src/soc/nvidia/tegra124/include/soc/pinmux.h
diff --git a/src/soc/nvidia/tegra124/pmc.h b/src/soc/nvidia/tegra124/include/soc/pmc.h
index 2dfdaadb60..2dfdaadb60 100644
--- a/src/soc/nvidia/tegra124/pmc.h
+++ b/src/soc/nvidia/tegra124/include/soc/pmc.h
diff --git a/src/soc/nvidia/tegra124/power.h b/src/soc/nvidia/tegra124/include/soc/power.h
index 889dede2dd..889dede2dd 100644
--- a/src/soc/nvidia/tegra124/power.h
+++ b/src/soc/nvidia/tegra124/include/soc/power.h
diff --git a/src/soc/nvidia/tegra124/sdram.h b/src/soc/nvidia/tegra124/include/soc/sdram.h
index d32ce37770..1571521995 100644
--- a/src/soc/nvidia/tegra124/sdram.h
+++ b/src/soc/nvidia/tegra124/include/soc/sdram.h
@@ -20,7 +20,7 @@
#ifndef __SOC_NVIDIA_TEGRA124_SDRAM_H__
#define __SOC_NVIDIA_TEGRA124_SDRAM_H__
-#include "sdram_param.h"
+#include <soc/sdram_param.h>
uint32_t sdram_get_ram_code(void);
void sdram_init(const struct sdram_params *param);
diff --git a/src/soc/nvidia/tegra124/sdram_param.h b/src/soc/nvidia/tegra124/include/soc/sdram_param.h
index c845611da0..c845611da0 100644
--- a/src/soc/nvidia/tegra124/sdram_param.h
+++ b/src/soc/nvidia/tegra124/include/soc/sdram_param.h
diff --git a/src/soc/nvidia/tegra124/sor.h b/src/soc/nvidia/tegra124/include/soc/sor.h
index 569cdb970b..569cdb970b 100644
--- a/src/soc/nvidia/tegra124/sor.h
+++ b/src/soc/nvidia/tegra124/include/soc/sor.h
diff --git a/src/soc/nvidia/tegra124/spi.h b/src/soc/nvidia/tegra124/include/soc/spi.h
index 11e88feec5..ab046323b1 100644
--- a/src/soc/nvidia/tegra124/spi.h
+++ b/src/soc/nvidia/tegra124/include/soc/spi.h
@@ -18,10 +18,9 @@
#define __NVIDIA_TEGRA124_SPI_H__
#include <spi-generic.h>
+#include <soc/dma.h>
#include <stddef.h>
-#include "dma.h"
-
struct tegra_spi_regs {
u32 command1; /* 0x000: SPI_COMMAND1 */
u32 command2; /* 0x004: SPI_COMMAND2 */
diff --git a/src/soc/nvidia/tegra124/sysctr.h b/src/soc/nvidia/tegra124/include/soc/sysctr.h
index 1d7f53c3e1..1d7f53c3e1 100644
--- a/src/soc/nvidia/tegra124/sysctr.h
+++ b/src/soc/nvidia/tegra124/include/soc/sysctr.h
diff --git a/src/soc/nvidia/tegra124/power.c b/src/soc/nvidia/tegra124/power.c
index 75f04942b9..825b27bda9 100644
--- a/src/soc/nvidia/tegra124/power.c
+++ b/src/soc/nvidia/tegra124/power.c
@@ -22,10 +22,9 @@
#include <console/console.h>
#include <soc/addressmap.h>
#include <soc/clock.h>
-
-#include "pmc.h"
-#include "power.h"
-#include "flow.h"
+#include <soc/flow.h>
+#include <soc/pmc.h>
+#include <soc/power.h>
static struct tegra_pmc_regs * const pmc = (void *)TEGRA_PMC_BASE;
static struct flow_ctlr * const flow = (void *)TEGRA_FLOW_BASE;
diff --git a/src/soc/nvidia/tegra124/sdram.c b/src/soc/nvidia/tegra124/sdram.c
index 82219b1da5..d094c18594 100644
--- a/src/soc/nvidia/tegra124/sdram.c
+++ b/src/soc/nvidia/tegra124/sdram.c
@@ -22,13 +22,13 @@
#include <delay.h>
#include <soc/addressmap.h>
#include <soc/clock.h>
+#include <soc/emc.h>
+#include <soc/mc.h>
+#include <soc/pmc.h>
+#include <soc/sdram.h>
#include <stdlib.h>
#include <symbols.h>
-#include "emc.h"
-#include "mc.h"
-#include "pmc.h"
-#include "sdram.h"
static void sdram_patch(uintptr_t addr, uint32_t value)
{
diff --git a/src/soc/nvidia/tegra124/sdram_lp0.c b/src/soc/nvidia/tegra124/sdram_lp0.c
index 0cd814ea2c..11e8bc0aba 100644
--- a/src/soc/nvidia/tegra124/sdram_lp0.c
+++ b/src/soc/nvidia/tegra124/sdram_lp0.c
@@ -17,12 +17,11 @@
#include <arch/cache.h>
#include <console/console.h>
-#include <stdlib.h>
#include <soc/addressmap.h>
-
-#include "clk_rst.h"
-#include "pmc.h"
-#include "sdram.h"
+#include <soc/clk_rst.h>
+#include <soc/pmc.h>
+#include <soc/sdram.h>
+#include <stdlib.h>
/*
* This function reads SDRAM parameters (and a few CLK_RST regsiter values) from
diff --git a/src/soc/nvidia/tegra124/soc.c b/src/soc/nvidia/tegra124/soc.c
index 5da41a9b04..58da1ebaf8 100644
--- a/src/soc/nvidia/tegra124/soc.c
+++ b/src/soc/nvidia/tegra124/soc.c
@@ -19,16 +19,17 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
+#include <arch/io.h>
#include <console/console.h>
#include <device/device.h>
-#include <arch/io.h>
#include <soc/nvidia/tegra/dc.h>
-#include <soc/nvidia/tegra124/sdram.h>
-#include "chip.h"
#include <soc/display.h>
+#include <soc/sdram.h>
#include <symbols.h>
#include <vendorcode/google/chromeos/chromeos.h>
+#include "chip.h"
+
/* this sucks, but for now, fb size/location are hardcoded.
* Will break if we get 2. Sigh.
* We assume it's all multiples of MiB for MMUs sake.
diff --git a/src/soc/nvidia/tegra124/sor.c b/src/soc/nvidia/tegra124/sor.c
index 3eaae0e8f9..3de63f9e99 100644
--- a/src/soc/nvidia/tegra124/sor.c
+++ b/src/soc/nvidia/tegra124/sor.c
@@ -14,26 +14,26 @@
*
*/
-#include <console/console.h>
#include <arch/io.h>
-#include <stdint.h>
-#include <lib.h>
-#include <stdlib.h>
-#include <delay.h>
-#include <soc/addressmap.h>
-#include <device/device.h>
-#include <stdlib.h>
-#include <string.h>
-#include <cpu/cpu.h>
#include <boot/tables.h>
#include <cbmem.h>
+#include <console/console.h>
+#include <cpu/cpu.h>
+#include <delay.h>
+#include <lib.h>
+#include <device/device.h>
+#include <soc/addressmap.h>
+#include <soc/clk_rst.h>
+#include <soc/clock.h>
+#include <soc/display.h>
#include <soc/nvidia/tegra/dc.h>
-#include "sor.h"
#include <soc/nvidia/tegra/displayport.h>
-#include "clk_rst.h"
-#include <soc/clock.h>
+#include <soc/sor.h>
+#include <stdint.h>
+#include <stdlib.h>
+#include <string.h>
+
#include "chip.h"
-#include <soc/display.h>
#define DEBUG_SOR 0
diff --git a/src/soc/nvidia/tegra124/spi.c b/src/soc/nvidia/tegra124/spi.c
index b88306bb4a..aefb4da0d6 100644
--- a/src/soc/nvidia/tegra124/spi.c
+++ b/src/soc/nvidia/tegra124/spi.c
@@ -18,23 +18,23 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
+#include <arch/cache.h>
+#include <arch/io.h>
#include <assert.h>
+#include <console/console.h>
#include <cbfs.h>
+#include <delay.h>
#include <inttypes.h>
+#include <soc/addressmap.h>
+#include <soc/dma.h>
+#include <soc/spi.h>
#include <spi-generic.h>
#include <spi_flash.h>
#include <stdint.h>
#include <stdlib.h>
#include <string.h>
#include <timer.h>
-#include <arch/cache.h>
-#include <arch/io.h>
-#include <console/console.h>
-#include <soc/addressmap.h>
-#include <delay.h>
-#include "dma.h"
-#include "spi.h"
#if defined(CONFIG_DEBUG_SPI) && CONFIG_DEBUG_SPI
# define DEBUG_SPI(x,...) printk(BIOS_DEBUG, "TEGRA_SPI: " x)
diff --git a/src/soc/nvidia/tegra124/uart.c b/src/soc/nvidia/tegra124/uart.c
index fd8074daa0..4af00e9906 100644
--- a/src/soc/nvidia/tegra124/uart.c
+++ b/src/soc/nvidia/tegra124/uart.c
@@ -17,10 +17,10 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
-#include <console/uart.h>
#include <arch/io.h>
#include <boot/coreboot_tables.h>
#include <console/console.h> /* for __console definition */
+#include <console/uart.h>
#include <drivers/uart/uart8250reg.h>
diff --git a/src/soc/nvidia/tegra124/verstage.c b/src/soc/nvidia/tegra124/verstage.c
index 2e5ddf276c..80324232a8 100644
--- a/src/soc/nvidia/tegra124/verstage.c
+++ b/src/soc/nvidia/tegra124/verstage.c
@@ -20,8 +20,8 @@
#include <arch/cache.h>
#include <arch/exception.h>
#include <console/console.h>
-#include <soc/nvidia/tegra124/cache.h>
-#include <soc/nvidia/tegra124/early_configs.h>
+#include <soc/cache.h>
+#include <soc/early_configs.h>
#include <stdlib.h>
#include <symbols.h>
#include <vendorcode/google/chromeos/chromeos.h>