diff options
Diffstat (limited to 'src/mainboard/lenovo/x1_carbon_gen1/romstage.c')
| -rw-r--r-- | src/mainboard/lenovo/x1_carbon_gen1/romstage.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/romstage.c b/src/mainboard/lenovo/x1_carbon_gen1/romstage.c index c12c1fcabf..a34d1dba22 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/romstage.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/romstage.c @@ -95,7 +95,13 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only) /* 4gb model = 0, 8gb model = 1 */ /* int extended_memory_version = get_gpio(44); */ - /* TODO: how do they differ? Guess only one slot is connected */ + + /* + * So far there is no need to parse gpio 44, as the 4GiB use + * the hynix or elpida memory and 8 GiB versions use samsung. + * All version use both channels. + * But we might miss some versions. + */ /* * GPIO45 GPIO25 @@ -105,10 +111,8 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only) * 1 1 reserved */ - /* We only support elpida and samsung. - Because the spd data is missing. */ - if (spd_index != 0 && spd_index != 2) - die("Unsupported Memory. Please add your SPD dump to coreboot."); + if (spd_index == 3) + die("Unsupported Memory. (detected 'reserved' memory configuration)."); memory = get_spd_data(spd_index); memcpy(&spd[0], memory, 256); |