summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/superio/fintek/f71805f/chip.h4
-rw-r--r--src/superio/fintek/f71805f/f71805f.h6
-rw-r--r--src/superio/fintek/f71805f/f71805f_early_serial.c14
3 files changed, 13 insertions, 11 deletions
diff --git a/src/superio/fintek/f71805f/chip.h b/src/superio/fintek/f71805f/chip.h
index 77bb9b92f7..355e019569 100644
--- a/src/superio/fintek/f71805f/chip.h
+++ b/src/superio/fintek/f71805f/chip.h
@@ -18,11 +18,11 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
+#include <uart8250.h>
+
struct chip_operations;
extern struct chip_operations superio_fintek_f71805f_ops;
-#include <uart8250.h>
-
struct superio_fintek_f71805f_config {
struct uart8250 com1, com2;
};
diff --git a/src/superio/fintek/f71805f/f71805f.h b/src/superio/fintek/f71805f/f71805f.h
index ed6b55e992..3627944373 100644
--- a/src/superio/fintek/f71805f/f71805f.h
+++ b/src/superio/fintek/f71805f/f71805f.h
@@ -18,12 +18,12 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
-/* Logical Device Numbers (LDN) */
+/* Logical Device Numbers (LDN). */
#define F71805F_FDC 0x00 /* Floppy */
#define F71805F_SP1 0x01 /* UART1 */
#define F71805F_SP2 0x02 /* UART2 */
#define F71805F_PP 0x03 /* Parallel Port */
#define F71805F_HWM 0x04 /* Hardware Monitor */
#define F71805F_GPIO 0x06 /* General Purpose I/O (GPIO) */
-#define F71805F_PME 0x0A /* Power Management Events (PME) */
-/* All others reserved */
+#define F71805F_PME 0x0a /* Power Management Events (PME) */
+/* All others reserved. */
diff --git a/src/superio/fintek/f71805f/f71805f_early_serial.c b/src/superio/fintek/f71805f/f71805f_early_serial.c
index 708d05987c..3c0406f59d 100644
--- a/src/superio/fintek/f71805f/f71805f_early_serial.c
+++ b/src/superio/fintek/f71805f/f71805f_early_serial.c
@@ -18,22 +18,24 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
-/* Pre-RAM driver for Fintek F81705F Super I/O chip. */
+/* Pre-RAM driver for the Fintek F81705F Super I/O chip. */
#include <arch/romcc_io.h>
#include "f71805f.h"
-static inline void pnp_enter_conf_state(device_t dev) {
- unsigned port = dev>>8;
+static inline void pnp_enter_conf_state(device_t dev)
+{
+ unsigned int port = dev >> 8;
outb(0x87, port);
}
-static void pnp_exit_conf_state(device_t dev) {
- unsigned port = dev>>8;
+static void pnp_exit_conf_state(device_t dev)
+{
+ unsigned int port = dev >> 8;
outb(0xaa, port);
}
-static void f71805f_enable_serial(device_t dev, unsigned iobase)
+static void f71805f_enable_serial(device_t dev, unsigned int iobase)
{
pnp_enter_conf_state(dev);
pnp_set_logical_device(dev);