summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/mainboard/google/hatch/variants/kohaku/gpio.c6
-rw-r--r--src/mainboard/google/hatch/variants/kohaku/overridetree.cb6
2 files changed, 5 insertions, 7 deletions
diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c
index 9654388087..7bf9a0cd5f 100644
--- a/src/mainboard/google/hatch/variants/kohaku/gpio.c
+++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c
@@ -23,7 +23,7 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_A0, NONE),
/* A6 : SERIRQ ==> NC */
PAD_NC(GPP_A6, NONE),
- /* A10 : PEN_RESET_ODL */
+ /* A10 : PEN_RESET_ODL for old revision devices */
PAD_CFG_GPO(GPP_A10, 1, DEEP),
/* A16 : EMR_GARAGE_DET (notification) */
PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST),
@@ -31,8 +31,8 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_A17, NONE),
/* A18 : ISH_GP0 ==> NC */
PAD_NC(GPP_A18, NONE),
- /* A19 : ISH_GP1 ==> NC */
- PAD_NC(GPP_A19, NONE),
+ /* A19 : PEN_RESET_ODL */
+ PAD_CFG_GPO(GPP_A19, 0, DEEP),
/* A20 : ISH_GP2 ==> NC */
PAD_NC(GPP_A20, NONE),
/* A22 : ISH_GP4 ==> NC */
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
index 8c7bb1ff9a..37914faa06 100644
--- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb
@@ -189,10 +189,8 @@ chip soc/intel/cannonlake
register "generic.desc" = ""WCOM Digitizer""
register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)"
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C15)"
- # TODO: We can't use GPP_A10 as reset_gpio due to its voltage level,
- # so we need to reassign it or remove it.
- #register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A10)"
- #register "generic.reset_delay_ms" = "1"
+ register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A19)"
+ register "generic.reset_delay_ms" = "1"
register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x1"
device i2c 0x09 on end