diff options
author | Angel Pons <th3fanbus@gmail.com> | 2021-03-18 14:12:32 +0100 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2021-03-24 07:54:34 +0000 |
commit | fa1befcb575c30f59d8622547974c92cde92eb98 (patch) | |
tree | c71e1d7aa94e0a1daecea0bcf4efdb383a983a47 /util | |
parent | 8c5994f92d2c23d011daaa39dbb0fab88425a1d2 (diff) |
device/azalia_device.c: Unify `wait_for_valid` timeouts
The timeout is never reached when the codec is functioning properly.
Using a small timeout value can result in spurious errors with some
codecs, e.g. a codec that is slow to respond but operates correctly.
When a codec is non-operative, the timeout is only reached once per
verb table, thus the impact on booting time is relatively small. So,
use a reasonably long enough timeout to cover all possible cases.
Remove the unconditional 25 µs delay and increase the timeout delay.
The new value of 1 ms is the maximum of all existing implementations.
Currently, the only boards using this code are AMD reference boards:
- AMD Bilby
- AMD Mandolin
- AMD Padmelon
Change-Id: Ia5e4829d404dcecdb9e7a377e896a319cb38531a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51634
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'util')
0 files changed, 0 insertions, 0 deletions