diff options
| author | Martin Roth <martinroth@google.com> | 2016-01-31 10:44:33 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-02-09 21:52:45 +0100 |
| commit | 15f4d8c1bb79ff1d0c545b4ed5f498177f585b83 (patch) | |
| tree | 08a63564e2218d7ac6111054e5de8a7b8c143b11 /util | |
| parent | eda794d2cc2bfe1fe32736dfb611eb01d0a23d04 (diff) | |
kconfig_lint: demote 'always defined' errors to warnings
To be able to run this as a lint-stable test, demote these to warnings
for now. After the current CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL
issues get fixed, these can be promoted again.
Change-Id: I1432980eb0c871fc61c12dcc351f8d46513a7965
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/13541
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'util')
| -rwxr-xr-x | util/lint/kconfig_lint | 4 | ||||
| -rw-r--r-- | util/lint/kconfig_lint_README | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 787ab6acba..b5a62d3aaa 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -186,7 +186,7 @@ sub check_for_ifdef { my $symbol = $3; if ( ( exists $symbols{$symbol} ) && ( $symbols{$symbol}{type} ne "string" ) ) { - show_error( "#ifdef 'CONFIG_$symbol' used at $file:$lineno." + show_warning( "#ifdef 'CONFIG_$symbol' used at $file:$lineno." . " Symbols of type '$symbols{$symbol}{type}' are always defined." ); } } @@ -205,7 +205,7 @@ sub check_for_ifdef { if ( $line =~ /^([^:]+):(\d+):.+defined\s*\(\s*CONFIG_$symbol.*(&&|\|\|)\s*!?\s*\(?\s*CONFIG_$symbol/ ); if ( ( exists $symbols{$symbol} ) && ( $symbols{$symbol}{type} ne "string" ) ) { - show_error( "defined 'CONFIG_$symbol' used at $file:$lineno." + show_warning( "defined 'CONFIG_$symbol' used at $file:$lineno." . " Symbols of type '$symbols{$symbol}{type}' are always defined." ); } } diff --git a/util/lint/kconfig_lint_README b/util/lint/kconfig_lint_README index 3c638f5e10..5a5eacdb88 100644 --- a/util/lint/kconfig_lint_README +++ b/util/lint/kconfig_lint_README @@ -57,6 +57,8 @@ Warnings in coreboot source files: symbols. - 'IS_ENABLED()' block that could not be interpreted. - Kconfig files that are not loaded by a 'source' keyword. +- '#ifdef' or '#if defined' used on bool, int, or hex - these are always + defined in coreboot's version of Kconfig. Errors in Kconfig files: - Selects do not work on symbols created in a choice block. @@ -89,8 +91,6 @@ Errors in Kconfig that are also caught by Kconfig itself: - Using a 'prompt' keyword not inside a config or choice block. Errors in coreboot source files: -- '#ifdef' or '#if defined' used on bool, int, or hex - these are always - defined in coreboot's version of Kconfig. - The IS_ENABLED macro is only valid for bool symbols. - The IS_ENABLED used on unknown CONFIG_ value, like an obsolete symbol. - The IS_ENABLED macro is used on a symbol without the CONFIG_ prefix. |