aboutsummaryrefslogtreecommitdiff
path: root/util
diff options
context:
space:
mode:
authorBenjamin Doron <benjamin.doron00@gmail.com>2021-06-09 20:19:03 +0000
committerPatrick Georgi <pgeorgi@google.com>2021-06-16 05:10:53 +0000
commitdfb6a0b1a3f03ca71ba684bc212fc5a8b52962f0 (patch)
tree2fe215540bf6546ec47306955549f6a393fd3bd2 /util
parentef5eb967ecc06b620f46065acc950bb70aaf6a7c (diff)
util/intelp2m/fsp: Update some deprecated macros
Avoid using deprecated macros, where possible. "GpioResetPwrGood" represents multiple valid updated values, depending on the GPIO community and will be more difficult to update. While Kabylake supports both sets of macros, it will cause build errors on Coffeelake. In the GPD group, replace with "GpioDswReset." Replace with "GpioResumeReset" in any GPP group. Change-Id: Iab0bb09adad997bef3a2133c443471d4c634f423 Signed-off-by: Benjamin Doron <benjamin.doron00@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/54974 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Maxim Polyakov <max.senia.poliak@gmail.com>
Diffstat (limited to 'util')
-rw-r--r--util/intelp2m/fields/fsp/fsp.go8
1 files changed, 4 insertions, 4 deletions
diff --git a/util/intelp2m/fields/fsp/fsp.go b/util/intelp2m/fields/fsp/fsp.go
index be3cde9dab..f7d3f3a007 100644
--- a/util/intelp2m/fields/fsp/fsp.go
+++ b/util/intelp2m/fields/fsp/fsp.go
@@ -121,10 +121,10 @@ func (FieldMacros) DecodeDW0() {
&field {
configmap : map[uint8]string {
- 0: "GpioResetPwrGood",
- 1: "GpioResetDeep",
- 2: "GpioResetNormal",
- 3: "GpioResetResume",
+ 0: "GpioResetPwrGood", // TODO: Has multiple values (to GPP and GPD)
+ 1: "GpioHostDeepReset",
+ 2: "GpioPlatformReset",
+ 3: "GpioResumeReset",
},
value : dw0.GetResetConfig(),
},