diff options
| author | Robert Zieba <robertzieba@google.com> | 2022-09-20 12:36:12 -0600 |
|---|---|---|
| committer | Karthik Ramasubramanian <kramasub@google.com> | 2022-09-29 17:12:00 +0000 |
| commit | de6ecd0101606cd2dcf9a970e8bd7784fb4962d9 (patch) | |
| tree | 3f4a1b920a35286833cfd42e90739acf3ccf65f7 /util | |
| parent | 45aae7f10ff2b2fc6a947eb2667eb658188d3b52 (diff) | |
util/spd_tools: Change Mendocino to use 0x13 for LP5x memory type
Mendocino supports LP5x but currently doesn't support SPDs that use the
LP5x memory type, 0x15. This commit updates set 1 SPDs, which are
currently only used for mendocino, to use 0x13 for their memory type.
BUG=b:245509394
TEST=Generated SPDs, verified that only set 1 have changed to 0x13
Change-Id: I46606cb5ff871296d0214e1f781c3b22e93d24ea
Signed-off-by: Robert Zieba <robertzieba@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67747
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Diffstat (limited to 'util')
| -rw-r--r-- | util/spd_tools/src/spd_gen/lp5.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/util/spd_tools/src/spd_gen/lp5.go b/util/spd_tools/src/spd_gen/lp5.go index bf7b8331e1..5d73cd5450 100644 --- a/util/spd_tools/src/spd_gen/lp5.go +++ b/util/spd_tools/src/spd_gen/lp5.go @@ -466,7 +466,9 @@ func LP5GetBankGroups(memAttribs *LP5MemAttributes) int { func LP5EncodeMemoryType(memAttribs *LP5MemAttributes) byte { var b byte - if memAttribs.LP5X { + // Mendocino supports LP5x, but doesn't support 0x15 as a memory type currently. + // Temporary workaround until it's supported with ABL changes + if memAttribs.LP5X && LP5CurrSet != 1 { b = LP5XSPDValueMemoryType } else { b = LP5SPDValueMemoryType |