diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2007-11-29 02:43:50 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2007-11-29 02:43:50 +0000 |
| commit | 59b99d9071b0381e197515cf94aede6e58a766a3 (patch) | |
| tree | 344d6fdde24193f91df64ce1da206b2b46dcc547 /util/superiotool/winbond.c | |
| parent | 8e290d38e4bb856b9d12cc3bc5acdd5d21e7f895 (diff) | |
Various small fixes (trivial).
- Add missing contributors to the README.
- Drop obsolete -D option from manpage.
- Only list contributors who added non-trivial amounts of code as copyright
holders (and do not list those who merely provided register dump support
for Super I/Os). Those contributors are still listed in the README,
of course. See discussion in the thread starting at
http://www.linuxbios.org/pipermail/linuxbios/2007-October/025516.html
- Make a function static.
- Fix incorrect URL in code comment. Drop obsolete comments.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2992 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'util/superiotool/winbond.c')
| -rw-r--r-- | util/superiotool/winbond.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/util/superiotool/winbond.c b/util/superiotool/winbond.c index f473e2dd7a..dca64fe0a6 100644 --- a/util/superiotool/winbond.c +++ b/util/superiotool/winbond.c @@ -2,7 +2,6 @@ * This file is part of the superiotool project. * * Copyright (C) 2007 Uwe Hermann <uwe@hermann-uwe.de> - * Copyright (C) 2007 Rasmus Wiman <rasmus@wiman.org> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -389,7 +388,7 @@ static void enter_conf_mode_winbond_86(uint16_t port) outb(0x86, port); } -void probe_idregs_winbond_helper(const char *init, uint16_t port) +static void probe_idregs_winbond_helper(const char *init, uint16_t port) { uint16_t id; uint8_t devid, rev, olddevid; @@ -425,14 +424,11 @@ void probe_idregs_winbond_helper(const char *init, uint16_t port) get_superio_name(reg_table, id), devid, rev, port); chip_found = 1; - /* TODO: Special notes in dump output for the MISC entries. */ dump_superio("Winbond", reg_table, port, id); } void probe_idregs_winbond(uint16_t port) { - /* TODO: Not all init sequences are valid for all ports. */ - enter_conf_mode_winbond_88(port); probe_idregs_winbond_helper("(init=0x88) ", port); exit_conf_mode_winbond_fintek_ite_8787(port); |