summaryrefslogtreecommitdiff
path: root/util/smmstoretool
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2024-05-13 16:38:54 +0200
committerNico Huber <nico.h@gmx.de>2024-08-05 08:58:11 +0000
commit52a1c61b97792ea592eeaa13a61692f4dd0580e8 (patch)
tree211ce8929cf7c20280bec4459e93dd43817f8776 /util/smmstoretool
parenta2180b33351e63187b6de834d3a3fd30ea8b500c (diff)
util/autoport: Streamline external program invocation
The original approach to call external programs was rather convoluted and would fall back to running executables inside the current working directory if running them from the location specified in the code did not succeed, swallowing any errors from the first invocation. Rewrite the system around the `LogMakingProgram` concept, a struct to represent a program. Each program has a name, prefixes to try running it from and the arguments to pass to it (if any). Plus, collect error information from failed executions, but only show it when none of the prefixes resulted in a successful invocation. In addition, look for programs in PATH instead of CWD: it is unlikely that all utils will be in the CWD, but utils can be in the PATH after one installs them (`sudo make install`). For coreboot utils, look for them in the utils folder first as the installed versions might not be up-to-date. Furthermore, print out the command about to be executed, as there are some commands (e.g. `ectool` on boards without an EC) that can take a very long time to complete. Change-Id: I144bdf609e0aebd8f6ddebc0eb1216bedebfa313 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82403 Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'util/smmstoretool')
0 files changed, 0 insertions, 0 deletions