diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2023-01-10 15:22:58 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-04-11 16:23:28 +0000 |
| commit | e84b095d3a238ae5fd734c4c186132a4e07eea07 (patch) | |
| tree | 24e2c7a3ed9050e26d5a1511e8946ced86f19cd5 /util/sconfig/main.c | |
| parent | 8b8400a889abadbbd2156d4a35a27203068766f1 (diff) | |
util/sconfig: Remove unused ioapic and irq keywords
Ioapic information in the devicetree was only used to set up mptables
but this generic driver was removed (ca5a793 drivers/generic/ioapic:
Drop poor implementation).
This removes the unused remainders from mainboard devicetrees.
Remove ioapic setup from sconfig.
Change-Id: Ib3fef0bf923ab3f02f3aeed2e55cf662a3dc3a1b
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71789
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Diffstat (limited to 'util/sconfig/main.c')
| -rw-r--r-- | util/sconfig/main.c | 43 |
1 files changed, 0 insertions, 43 deletions
diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 6618a45b1a..aa79f1e187 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -881,10 +881,6 @@ static struct device *new_device_with_path(struct bus *parent, new_d->path = ".type=DEVICE_PATH_DOMAIN,{.domain={ .domain = 0x%x }}"; break; - case IOAPIC: - new_d->path = ".type=DEVICE_PATH_IOAPIC,{.ioapic={ .ioapic_id = 0x%x }}"; - break; - case GENERIC: new_d->path = ".type=DEVICE_PATH_GENERIC,{.generic={ .id = 0x%x, .subid = 0x%x }}"; break; @@ -1084,33 +1080,6 @@ void add_pci_subsystem_ids(struct bus *bus, int vendor, int device, dev->inherit_subsystem = inherit; } -void add_ioapic_info(struct bus *bus, int apicid, const char *_srcpin, - int irqpin) -{ - int srcpin; - struct device *dev = bus->dev; - - if (!_srcpin || strlen(_srcpin) < 4 || strncasecmp(_srcpin, "INT", 3) || - _srcpin[3] < 'A' || _srcpin[3] > 'D') { - printf("ERROR: malformed ioapic_irq args: %s\n", _srcpin); - exit(1); - } - - srcpin = _srcpin[3] - 'A'; - - if (dev->bustype != PCI && dev->bustype != DOMAIN) { - printf("ERROR: ioapic config only allowed for PCI devices\n"); - exit(1); - } - - if (srcpin > 3) { - printf("ERROR: srcpin '%d' invalid\n", srcpin); - exit(1); - } - dev->pci_irq_info[srcpin].ioapic_irq_pin = irqpin; - dev->pci_irq_info[srcpin].ioapic_dst_id = apicid; -} - static int dev_has_children(struct device *dev) { struct bus *bus = dev->bus; @@ -1269,7 +1238,6 @@ static struct chip_instance *get_chip_instance(const struct device *dev) static void pass1(FILE *fil, FILE *head, struct device *ptr, struct device *next) { - int pin; struct chip_instance *chip_ins = get_chip_instance(ptr); int has_children = dev_has_children(ptr); @@ -1333,17 +1301,6 @@ static void pass1(FILE *fil, FILE *head, struct device *ptr, struct device *next if (ptr->probe) fprintf(fil, "\t.probe_list = %s_probe_list,\n", ptr->name); fprintf(fil, "#if !DEVTREE_EARLY\n"); - for (pin = 0; pin < 4; pin++) { - if (ptr->pci_irq_info[pin].ioapic_irq_pin > 0) - fprintf(fil, - "\t.pci_irq_info[%d].ioapic_irq_pin = %d,\n", - pin, ptr->pci_irq_info[pin].ioapic_irq_pin); - - if (ptr->pci_irq_info[pin].ioapic_dst_id > 0) - fprintf(fil, - "\t.pci_irq_info[%d].ioapic_dst_id = %d,\n", - pin, ptr->pci_irq_info[pin].ioapic_dst_id); - } fprintf(fil, "\t.chip_ops = &%s_ops,\n", chip_ins->chip->name_underscore); if (chip_ins == &mainboard_instance) |