diff options
author | Denis 'GNUtoo' Carikli <GNUtoo@no-log.org> | 2012-05-26 00:13:22 +0200 |
---|---|---|
committer | Patrick Georgi <patrick@georgi-clan.de> | 2012-05-30 08:32:38 +0200 |
commit | 7c2d058d61f53d5b739fbde8e1c63b59776e9c0b (patch) | |
tree | 78eedabc55dd03db5f3cf75bde510b21066a7627 /util/sconfig/main.c | |
parent | 3b3a1a1ee65087d5b894e964f5bc4615c07389ae (diff) |
Fix the location of "Setting variable MTRR" printk.
Without that fix the debugging is harder because the person debugging
coreboot will see the following twice(note the repeated MTRR number):
Setting variable MTRR 0, base: 0MB, range: 4096MB, type WB
[...]
Setting variable MTRR 1, base: 4096MB, range: 512MB, type WB
Setting variable MTRR 1, base: 4608MB, range: 256MB, type WB
Setting variable MTRR 1, base: 3072MB, range: 1024MB, type UC
instead of the following twice:
Setting variable MTRR 0, base: 0MB, range: 4096MB, type WB
[...]
Setting variable MTRR 1, base: 3072MB, range: 1024MB, type UC
Thanks to kmalkki on #coreboot's Freenode IRC channel for the idea:
May 25 23:57:17 <kmalkki> I would add (move) that "Setting variable MTRR..." debug at the end of set_var_mtrrs()
Change-Id: I9f4b7110ba34d017a58d8cc5fb06a7b1c3d0c8aa
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Reviewed-on: http://review.coreboot.org/1058
Tested-by: build bot (Jenkins)
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Diffstat (limited to 'util/sconfig/main.c')
0 files changed, 0 insertions, 0 deletions