summaryrefslogtreecommitdiff
path: root/util/nvramtool/ip_checksum.h
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2012-02-28 01:45:44 +0200
committerPatrick Georgi <patrick@georgi-clan.de>2012-03-31 11:55:54 +0200
commitf9d1a42d98b121088b0c242b4d9f5d0eb78d38de (patch)
treed45a68af912e6c4287a1a1645701252330f794b2 /util/nvramtool/ip_checksum.h
parent325b92f64a62f355715a45470e41407ce3c39c1e (diff)
Intel cpus: apply some good programming practices in new CAR
Delete dead CAR code and whitespace fixes. Replace cryptic 32bit hex values with existing LAPIC definitions. Do not assume state of direction flag before "rep" instruction. Do not load immediate values on temporary registers when not needed. Parameter pushed on stack was not popped (or flushed) after returning from call. This is a sort-of memory leak if multiple call's are implemented the same way. Change-Id: Ibb93e889b3a0af87b89345c462e331881e78686a Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/643 Tested-by: build bot (Jenkins) Reviewed-by: Idwer Vollering <vidwer@gmail.com> Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'util/nvramtool/ip_checksum.h')
0 files changed, 0 insertions, 0 deletions