aboutsummaryrefslogtreecommitdiff
path: root/util/mainboard/google/hatch/create_coreboot_variant.sh
diff options
context:
space:
mode:
authorPaul Fagerburg <pfagerburg@chromium.org>2019-12-10 13:57:06 -0700
committerPatrick Georgi <pgeorgi@google.com>2019-12-12 15:08:55 +0000
commit149d523c9a52446bbcf38fa0b5afc9b0c722efb9 (patch)
tree6857daf230b1a5e7c9617ac917b577270ddf12a1 /util/mainboard/google/hatch/create_coreboot_variant.sh
parent32bae49435bc6eb2f590ad685ff63076c5c16436 (diff)
util/hatch: remove GBB_HWID, clean up user-visible output
* GBB_HWID is no longer used in Hatch Kconfig, so remove the code that creates the GBB_HWID and adds it to the Kconfig section * Add more information in the usage message when the cmdline params are incorrect. * Remove messages that tell the user what to do, because the top-level program that invokes this script will handle those commands, and so this script telling the user what to do is noise (and possibly harmful) * Add more information to the commit message that the script prepares for the user. * Bump script version number. BRANCH=None BUG=b:140261109 TEST=Create the "sushi" variant of the "hatch" baseboard: `util/mainboard/google/hatch/create_coreboot_variant.sh sushi` Inspect the files in src/mainboard/google/hatch/variants/sushi Change-Id: I04e949aedce61ed7fc7df681b72c3cfef31b5513 Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37647 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Justin TerAvest <teravest@chromium.org>
Diffstat (limited to 'util/mainboard/google/hatch/create_coreboot_variant.sh')
-rwxr-xr-xutil/mainboard/google/hatch/create_coreboot_variant.sh14
1 files changed, 7 insertions, 7 deletions
diff --git a/util/mainboard/google/hatch/create_coreboot_variant.sh b/util/mainboard/google/hatch/create_coreboot_variant.sh
index 184e54c810..beaf302580 100755
--- a/util/mainboard/google/hatch/create_coreboot_variant.sh
+++ b/util/mainboard/google/hatch/create_coreboot_variant.sh
@@ -13,7 +13,7 @@
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
-VERSION="1.0.0"
+VERSION="1.0.1"
SCRIPT=$(basename -- "${0}")
export LC_ALL=C
@@ -21,9 +21,8 @@ export LC_ALL=C
if [[ "$#" -lt 1 ]]; then
echo "Usage: ${SCRIPT} variant_name [b:bug_number]"
echo "e.g. ${SCRIPT} kohaku b:140261109"
- echo "Adds a new variant of Hatch to Kconfig and Kconfig.name, creates the"
- echo "skeleton files for acpi, ec, and gpio, copies the makefile for"
- echo "SPD sources, and sets up a basic overridetree"
+ echo "* Adds a new variant of the baseboard to Kconfig and Kconfig.name"
+ echo "* Copies the template files for the baseboard to the new variant"
exit 1
fi
@@ -78,11 +77,12 @@ git add Kconfig Kconfig.name
# Now commit the files.
git commit -sm "${BASE}: Create ${VARIANT} variant
+Create the ${VARIANT} variant of the ${BASE} baseboard by
+copying the baseboard template files to a new directory
+named for the variant.
+
(Auto-Generated by ${SCRIPT} version ${VERSION}).
BUG=${BUG}
TEST=util/abuild/abuild -p none -t google/${BASE} -x -a
make sure the build includes GOOGLE_${VARIANT_UPPER}"
-
-echo "Please check all the files (git show), make any changes you want,"
-echo "and then push to coreboot HEAD:refs/for/master"