aboutsummaryrefslogtreecommitdiff
path: root/util/lint
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2016-01-19 21:03:04 -0700
committerPatrick Georgi <pgeorgi@google.com>2016-01-21 12:31:53 +0100
commit6966759edb84f5158f3daad4098a18d11f699cf7 (patch)
tree3a7446e57390f078046d9cdbab07d72bce3e3b6f /util/lint
parent6720394ffc6df0f654307a2c3f471418876725b5 (diff)
util/lint: Fix linter for old license headers
Somehow I lost a $ on headerlist between when I tested the script and when I submitted it, turning headerlist into plain text instead of a variable name. This makes the test always pass. - Fix variable bug. - exclude this script from the check. - update test for empty HEADER_DIRS variable. Change-Id: I6080c520bc741e9d689f7c66ee97879afc8ba38c Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/13057 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'util/lint')
-rwxr-xr-xutil/lint/lint-stable-009-old-licenses6
1 files changed, 3 insertions, 3 deletions
diff --git a/util/lint/lint-stable-009-old-licenses b/util/lint/lint-stable-009-old-licenses
index 702798f0cc..9d9eb9f43c 100755
--- a/util/lint/lint-stable-009-old-licenses
+++ b/util/lint/lint-stable-009-old-licenses
@@ -29,10 +29,10 @@ HEADER_EXCLUDED="\
_shipped$|\
^util/scripts/no-fsf-addresses.sh|\
^util/lint/lint-000-license-headers|\
-^util/lint/lint-stable-000-license-headers\
+^util/lint/lint-stable-009-old-licenses\
"
-if [ "$HEADER_DIRS" = "" ]; then
+if [ -z "$HEADER_DIRS" ]; then
HEADER_DIRS="src util"
fi
@@ -42,7 +42,7 @@ headerlist=$(git ls-files $HEADER_DIRS | egrep -v "($HEADER_EXCLUDED)")
#check for the old style header
headerlist=$(grep -il "You should have received a copy of the GNU" \
- headerlist 2>/dev/null)
+ $headerlist 2>/dev/null)
for file in $headerlist; do
echo "$file has the old GPL header."