diff options
| author | Martin Roth <martinroth@google.com> | 2016-10-03 23:00:04 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-10-03 23:13:09 +0200 |
| commit | a7d002708319dd976c1475f5e096bca4fd92fb8e (patch) | |
| tree | 5f4aadc00c9bbdc5cf73f0eb45f8d32ca2e2f191 /util/lint | |
| parent | 6d6c00a50237dd8c9102fd24cb183ceda1aa90ac (diff) | |
Revert "util/lint/kconfig_lint: change warning levels and text"
This reverts commit dfdb0733a6a71b11d15006dafc13841e84fab7cd.
Change-Id: I91bf5e42f4ac241f544742ce161bae651f9f9947
Reviewed-on: https://review.coreboot.org/16868
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'util/lint')
| -rwxr-xr-x | util/lint/kconfig_lint | 18 |
1 files changed, 5 insertions, 13 deletions
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index 39a02910ca..064f3db33f 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -197,11 +197,8 @@ sub check_for_ifdef { my $symbol = $3; if ( ( exists $symbols{$symbol} ) && ( $symbols{$symbol}{type} ne "string" ) ) { - # TODO: Remove special check for CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL - if ($symbol ne "MAINBOARD_POWER_ON_AFTER_POWER_FAIL") { - show_error( "#ifdef 'CONFIG_$symbol' used at $file:$lineno." + show_warning( "#ifdef 'CONFIG_$symbol' used at $file:$lineno." . " Symbols of type '$symbols{$symbol}{type}' are always defined." ); - } } } } @@ -264,10 +261,7 @@ sub check_for_def { my $symbol = $3; if ( ( exists $symbols{$symbol} ) ) { - # TODO: Remove special check for CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL - if ($symbol ne "MAINBOARD_POWER_ON_AFTER_POWER_FAIL") { - show_error("#define of symbol 'CONFIG_$symbol' used at $file:$lineno."); - } + show_warning("#define of symbol 'CONFIG_$symbol' used at $file:$lineno."); } else { show_warning( "#define 'CONFIG_$symbol' used at $file:$lineno." @@ -466,9 +460,7 @@ sub check_used_symbols { for ( my $i = 0 ; $i <= $symbols{$key}{count} ; $i++ ) { my $filename = $symbols{$key}{$i}{file}; my $line_no = $symbols{$key}{$i}{line_no}; - if ($show_note_output) { - print("#!!!!! Note: Unused symbol '$key' defined at $filename:$line_no."); - } + show_warning("Unused symbol '$key' referenced at $filename:$line_no."); } } } @@ -1170,9 +1162,9 @@ sub load_kconfig_file { #if the file exists, try to load it. elsif ( -e "$input_file" ) { - #throw an error if the file has already been loaded. + #throw a warning if the file has already been loaded. if ( exists $loaded_files{$input_file} ) { - show_error("'$input_file' sourced at $loadfile:$loadline was already loaded by $loaded_files{$input_file}"); + show_warning("'$input_file' sourced at $loadfile:$loadline was already loaded by $loaded_files{$input_file}"); } #load the file's contents and mark the file as loaded for checking later |