diff options
| author | Martin Roth <martin@coreboot.org> | 2022-06-03 00:06:57 -0600 |
|---|---|---|
| committer | Martin L Roth <gaumless@gmail.com> | 2022-09-30 19:19:53 +0000 |
| commit | d81debd9467f7e0d5a255ed7f6b5f1916c613b77 (patch) | |
| tree | 224623fc3af10180d652c7c0d7c39925e74e3763 /util/lint/lint-extended-020-signed-off-by | |
| parent | 7726a7f272965d9279e4c8008b893751203aa304 (diff) | |
util/lint: Update tools that use git to use a library
Each of the tools that used git had similar functionality. This combines
all of that into a single script that gets sourced by each. This makes
maintenance much easier.
By doing this and updating each of the scripts to do the correct thing
if the script isn't being run in a git repository, it makes them work
much better for the releases, which are just released as a tarball,
without any attached git repository.
Change-Id: I61ba1cc4f7205e0d4baf993588bbc774120405cb
Signed-off-by: Martin Roth <martin@coreboot.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64973
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Diffstat (limited to 'util/lint/lint-extended-020-signed-off-by')
| -rwxr-xr-x | util/lint/lint-extended-020-signed-off-by | 23 |
1 files changed, 16 insertions, 7 deletions
diff --git a/util/lint/lint-extended-020-signed-off-by b/util/lint/lint-extended-020-signed-off-by index 6d569aa80a..abbed56a24 100755 --- a/util/lint/lint-extended-020-signed-off-by +++ b/util/lint/lint-extended-020-signed-off-by @@ -1,13 +1,22 @@ #!/usr/bin/env sh # SPDX-License-Identifier: GPL-2.0-or-later # -# DESCR: Check for a signed-off-by line on the latest git commit +# DESCR: Check for a signed-off-by line on the latest commit + + +LINTDIR="$( + cd -- "$(dirname "$0")" > /dev/null 2>&1 || return + pwd -P +)" + +# shellcheck source=helper_functions.sh +. "${LINTDIR}/helper_functions.sh" + +if [ "${IN_GIT_TREE}" -eq 0 ]; then + exit 0 +fi # This test is mainly for the jenkins server -if [ -n "$(command -v git)" ] && \ - [ "$(git rev-parse --is-inside-work-tree 2>/dev/null)" = "true" ] -then - if [ -z "$(git log -n 1 | grep '[[:space:]]\+Signed-off-by: ')" ]; then - echo "No Signed-off-by line in commit message" - fi +if ! ${GIT} log -n 1 | grep -q '[[:space:]]\+Signed-off-by: '; then + echo "No Signed-off-by line in commit message" fi |