diff options
author | Patrick Georgi <patrick@georgi-clan.de> | 2014-04-11 20:24:06 +0200 |
---|---|---|
committer | Patrick Georgi <patrick@georgi-clan.de> | 2014-05-07 19:39:28 +0200 |
commit | d520840d4ca7d8fbd9c64946ee5f2d7ea44b8557 (patch) | |
tree | 0d51d363fe7ea38242199dc70edd48833d360657 /util/kconfig/util.c | |
parent | 99d8818af332f4db8ded058c7e5e59e2f56f7bc9 (diff) |
kconfig: update to follow upstream more closely
This might break a bunch of stuff (eg. win32 support),
but otherwise introduces nconfig (ncurses based configuration
frontend), partial configuration headers for improved dependency
tracking (which requires some more build system support) and
various bug fixes.
Change-Id: I5d8a280810c6a26fc3fd056d5d94cb9e591a0ff5
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/5487
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Diffstat (limited to 'util/kconfig/util.c')
-rw-r--r-- | util/kconfig/util.c | 52 |
1 files changed, 41 insertions, 11 deletions
diff --git a/util/kconfig/util.c b/util/kconfig/util.c index a47d5e0fdc..960747c3fb 100644 --- a/util/kconfig/util.c +++ b/util/kconfig/util.c @@ -5,6 +5,8 @@ * Released under the terms of the GNU GPL v2.0. */ +#include <stdarg.h> +#include <stdlib.h> #include <string.h> #include "lkc.h" @@ -12,15 +14,18 @@ struct file *file_lookup(const char *name) { struct file *file; + const char *file_name = sym_expand_string_value(name); for (file = file_list; file; file = file->next) { - if (!strcmp(name, file->name)) + if (!strcmp(name, file->name)) { + free((void *)file_name); return file; + } } - file = malloc(sizeof(*file)); + file = xmalloc(sizeof(*file)); memset(file, 0, sizeof(*file)); - file->name = strdup(name); + file->name = file_name; file->next = file_list; file_list = file; return file; @@ -33,10 +38,14 @@ int file_write_dep(const char *name) struct expr *e; struct file *file; FILE *out; + int i; if (!name) name = ".kconfig.d"; - out = fopen("..config.tmp", "w"); + char *config_tmp_name = strdup("..config.tmp.XXXXXX"); + if ((i = mkstemp(config_tmp_name)) == -1) + return 1; + out = fdopen(i, "w"); if (!out) return 1; fprintf(out, "deps_config := \\\n"); @@ -46,8 +55,8 @@ int file_write_dep(const char *name) else fprintf(out, "\t%s\n", file->name); } - fprintf(out, "\nbuild/auto.conf: \\\n" - "\t$(deps_config)\n\n"); + fprintf(out, "\n%s: \\\n" + "\t$(deps_config)\n\n", conf_get_autoconfig_name()); expr_list_for_each_sym(sym_env_list, e, sym) { struct property *prop; @@ -61,23 +70,24 @@ int file_write_dep(const char *name) if (!value) value = ""; fprintf(out, "ifneq \"$(%s)\" \"%s\"\n", env_sym->name, value); - fprintf(out, "build/auto.conf: FORCE\n"); + fprintf(out, "%s: FORCE\n", conf_get_autoconfig_name()); fprintf(out, "endif\n"); } fprintf(out, "\n$(deps_config): ;\n"); fclose(out); - rename("..config.tmp", name); + rename(config_tmp_name, name); return 0; } -/* Allocate initial growable sting */ +/* Allocate initial growable string */ struct gstr str_new(void) { struct gstr gs; - gs.s = malloc(sizeof(char) * 64); - gs.len = 16; + gs.s = xmalloc(sizeof(char) * 64); + gs.len = 64; + gs.max_width = 0; strcpy(gs.s, "\0"); return gs; } @@ -88,6 +98,7 @@ struct gstr str_assign(const char *s) struct gstr gs; gs.s = strdup(s); gs.len = strlen(s) + 1; + gs.max_width = 0; return gs; } @@ -131,3 +142,22 @@ const char *str_get(struct gstr *gs) return gs->s; } +void *xmalloc(size_t size) +{ + void *p = malloc(size); + if (p) + return p; + fprintf(stderr, "Out of memory.\n"); + exit(1); +} + +void *xcalloc(size_t nmemb, size_t size) +{ + void *p = calloc(nmemb, size); + if (p) + return p; + fprintf(stderr, "Out of memory.\n"); + exit(1); +} + + |