diff options
author | Felix Held <felix-coreboot@felixheld.de> | 2021-02-02 21:30:25 +0100 |
---|---|---|
committer | Felix Held <felix-coreboot@felixheld.de> | 2021-02-23 01:32:14 +0000 |
commit | a09559501c06e3cab420908bd667af4486ec0ba5 (patch) | |
tree | 1f9ff2e768cddcf41a519ec2e82e37c7a98b7bfc /util/inteltool/powermgt.c | |
parent | ca5ed4879fd859b050682591459113f39d4caf84 (diff) |
drivers/intel/fsp2_0/memory_init: check if UPD struct has expected size
If the UPD size in coreboot sizes mismatches the one from the FSP-M
binary, we're running into trouble. If the expected size is smaller than
the UPD size the FSP provides, call die(), since the target buffer isn't
large enough so only the beginning of the UPD defaults from the FSP will
get copied into the buffer. We ran into the issue in soc/amd/cezanne,
where the UPD struct in coreboot was smaller than the one in the FSP, so
the defaults didn't get completely copied.
TEST=Mandolin still boots.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ia7e9f6f20d0091bbb4abfd42abb40b485da2079d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50241
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'util/inteltool/powermgt.c')
0 files changed, 0 insertions, 0 deletions