summaryrefslogtreecommitdiff
path: root/util/ifdtool
diff options
context:
space:
mode:
authorJacob Garber <jgarber1@ualberta.ca>2019-06-25 11:59:59 -0600
committerPatrick Georgi <pgeorgi@google.com>2019-07-23 09:09:32 +0000
commit768db4f5ca93d4dad1f5104e1a3676c40ad85a55 (patch)
treec0cb2d6db59fa24ae180b827588b673c0842822c /util/ifdtool
parent65fe2948a91529c858fdae23a45408ca06953fcf (diff)
libpayload/libc: Correct strlcat return value
The documented return value for strlcat is horribly wrong, as is the return value itself. It should not return the number of appended bytes, but rather the length of the concatenated string. From the man page: The strlcpy() and strlcat() functions return the total length of the string they tried to create. For strlcpy() that means the length of src. For strlcat() that means the initial length of dst plus the length of src. While this may seem somewhat confusing, it was done to make truncation detection simple. This change is more likely to fix existing code than break it, since anyone who uses the return value of strlcat will almost certainly rely on the standard behaviour rather than investigate coreboot's source code to see that we have a quirky version. Change-Id: I4421305af85bce88d12d6fdc2eea6807ccdcf449 Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33787 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Julius Werner <jwerner@chromium.org>
Diffstat (limited to 'util/ifdtool')
0 files changed, 0 insertions, 0 deletions