diff options
| author | Stephan Guilloux <stephan.guilloux@free.fr> | 2009-04-25 22:07:28 +0000 |
|---|---|---|
| committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-04-25 22:07:28 +0000 |
| commit | baa4374cad5fe7e870a8ad7b95f7852f1ae2ee81 (patch) | |
| tree | bd705490b418c3f0e0e16d744762c383a4571f5c /util/flashrom | |
| parent | dcce5210c7c9b1f81cb1a968a9f9d91e2f719bb5 (diff) | |
The flashrom makefile wants to redirect both stdout and stderr to
/dev/null for one compile test.
The old variant of using &>/dev/null works on bash and zsh, but not on
dash and tcsh. dash and tcsh interpret it as "background command and
truncate /dev/null" which is not what we want. >& works on tcsh and
bash, but it is not POSIX compliant.
Since make uses /bin/sh and /bin/sh has to be POSIX compliant, we can
use the POSIX variant of stderr and stdout redirection.
>/dev/null 2>&1
is POSIX compliant. This is specified in SuSv3, Shell Command Language,
sections 2.7.2 and 2.7.6.
Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr>
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Ward Vandewege <ward@gnu.org>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4211 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'util/flashrom')
| -rw-r--r-- | util/flashrom/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/util/flashrom/Makefile b/util/flashrom/Makefile index cf9570a6bc..4699784c07 100644 --- a/util/flashrom/Makefile +++ b/util/flashrom/Makefile @@ -65,7 +65,7 @@ pciutils: echo "struct pci_access *pacc;"; \ echo "int main(int argc, char **argv)"; \ echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c ) - @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null && \ + @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \ echo "found." || ( echo "not found."; echo; \ echo "Please install pciutils-devel and zlib-devel."; \ echo "See README for more information."; echo; \ |