summaryrefslogtreecommitdiff
path: root/util/flashrom/pm49fl00x.c
diff options
context:
space:
mode:
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2009-03-05 19:24:22 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2009-03-05 19:24:22 +0000
commitac12ecd27a8e32a02193ea22dc36c89a060cc22e (patch)
tree278f567c693fcc0f1b46149bb1f571d655661c30 /util/flashrom/pm49fl00x.c
parent51001fbd81543d738a07cd36063fe5705eeff3ad (diff)
flashrom: Use helper functions to access flash chips.
Right now we perform direct pointer manipulation without any abstraction to read from and write to memory mapped flash chips. That makes it impossible to drive any flasher which does not mmap the whole chip. Using helper functions readb() and writeb() allows a driver for external flash programmers like Paraflasher to replace readb and writeb with calls to its own chip access routines. This patch has the additional advantage of removing lots of unnecessary casts to volatile uint8_t * and now-superfluous parentheses which caused poor readability. I used the semantic patcher Coccinelle to create this patch. The semantic patch follows: @@ expression a; typedef uint8_t; volatile uint8_t *b; @@ - *(b) = (a); + writeb(a, b); @@ volatile uint8_t *b; @@ - *(b) + readb(b) @@ type T; T b; @@ ( readb | writeb ) (..., - (T) - (b) + b ) In contrast to a sed script, the semantic patch performs type checking before converting anything. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: FENG Yu Ning <fengyuning1984@gmail.com> Tested-by: Joe Julian git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3971 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'util/flashrom/pm49fl00x.c')
-rw-r--r--util/flashrom/pm49fl00x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/util/flashrom/pm49fl00x.c b/util/flashrom/pm49fl00x.c
index fe8b9741b4..e2ca7b6660 100644
--- a/util/flashrom/pm49fl00x.c
+++ b/util/flashrom/pm49fl00x.c
@@ -35,7 +35,7 @@ void write_lockbits_49fl00x(volatile uint8_t *bios, int size,
if (block_size == 16384 && i % 2)
continue;
- *(bios + (i * block_size) + 2) = bits;
+ writeb(bits, bios + (i * block_size) + 2);
}
}