diff options
author | Sol Boucher <solb@chromium.org> | 2015-05-07 21:12:28 -0700 |
---|---|---|
committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2015-05-13 22:24:39 +0200 |
commit | 6310ccc59c1fd87ec5f68c1b0681e70500261e08 (patch) | |
tree | fb1f0ead736a9f91697606eae6bb08f3a0591025 /util/cbfstool/common.h | |
parent | 67d5998d9778ef6f740aac4ed1c93fb311b32ebe (diff) |
cbfstool: Don't typedef the comp_algo enum
Our style discourages unnecessary typedefs, and this one doesn't gain
us anything, nor is it consistent with the surrounding code: there's
a function pointer typedef'd nearby, but non-opaque structs aren't.
BUG=chromium:482652
TEST=None
BRANCH=None
Change-Id: Ie7565240639e5b1aeebb08ea005099aaa3557a27
Signed-off-by: Sol Boucher <solb@chromium.org>
Original-Change-Id: I4285e6b56f99b85b9684f2b98b35e9b35a6c4cb7
Original-Signed-off-by: Sol Boucher <solb@chromium.org>
Reviewed-on: http://review.coreboot.org/10146
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'util/cbfstool/common.h')
-rw-r--r-- | util/cbfstool/common.h | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/util/cbfstool/common.h b/util/cbfstool/common.h index 392ec80bb1..ddec1a7e68 100644 --- a/util/cbfstool/common.h +++ b/util/cbfstool/common.h @@ -154,28 +154,28 @@ const char *arch_to_string(uint32_t a); uint32_t string_to_arch(const char *arch_string); typedef int (*comp_func_ptr) (char *, int, char *, int *); -typedef enum { CBFS_COMPRESS_NONE = 0, CBFS_COMPRESS_LZMA = 1 } comp_algo; +enum comp_algo { CBFS_COMPRESS_NONE = 0, CBFS_COMPRESS_LZMA = 1 }; -comp_func_ptr compression_function(comp_algo algo); +comp_func_ptr compression_function(enum comp_algo algo); uint64_t intfiletype(const char *name); /* cbfs-mkpayload.c */ int parse_elf_to_payload(const struct buffer *input, struct buffer *output, - comp_algo algo); -int parse_fv_to_payload(const struct buffer *input, - struct buffer *output, comp_algo algo); + enum comp_algo algo); +int parse_fv_to_payload(const struct buffer *input, struct buffer *output, + enum comp_algo algo); int parse_bzImage_to_payload(const struct buffer *input, struct buffer *output, const char *initrd, - char *cmdline, comp_algo algo); + char *cmdline, enum comp_algo algo); int parse_flat_binary_to_payload(const struct buffer *input, struct buffer *output, uint32_t loadaddress, uint32_t entrypoint, - comp_algo algo); + enum comp_algo algo); /* cbfs-mkstage.c */ int parse_elf_to_stage(const struct buffer *input, struct buffer *output, - comp_algo algo, uint32_t *location, + enum comp_algo algo, uint32_t *location, const char *ignore_section); void print_supported_filetypes(void); |