aboutsummaryrefslogtreecommitdiff
path: root/util/cbfstool/common.c
diff options
context:
space:
mode:
authorStefan Reinauer <stefan.reinauer@coreboot.org>2015-03-04 00:55:03 +0100
committerStefan Reinauer <stefan.reinauer@coreboot.org>2015-03-04 19:53:20 +0100
commit2dd161f556eb0bfb4f092d35397fd04c98d1a3fb (patch)
treed6f2383983dcd849c4a78459ef7aa9d68c616915 /util/cbfstool/common.c
parent3aca2cdced54ff525022366bc6dee949b0152d83 (diff)
cbfstool: Clean up code
cbfstool has diverged between coreboot upstream and the chromium tree. Bring in some of the chromium changes, in particular the useful remainders of cbf37fe (https://chromium-review.googlesource.com/176710) - fix coding style - mark unused variables explicitly unused - remove some dead code Change-Id: I354aaede8ce425ebe99d4c60c232feea62bf8a11 Signed-off-by: Stefan Reinauer <reinauer@google.com> Reviewed-on: http://review.coreboot.org/8577 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones <marc.jones@se-eng.com>
Diffstat (limited to 'util/cbfstool/common.c')
-rw-r--r--util/cbfstool/common.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/util/cbfstool/common.c b/util/cbfstool/common.c
index bd9cdc0aa5..6ac39ef826 100644
--- a/util/cbfstool/common.c
+++ b/util/cbfstool/common.c
@@ -53,7 +53,8 @@ static off_t get_file_size(FILE *f)
}
/* Buffer and file I/O */
-int buffer_create(struct buffer *buffer, size_t size, const char *name) {
+int buffer_create(struct buffer *buffer, size_t size, const char *name)
+{
buffer->name = strdup(name);
buffer->size = size;
buffer->data = (char *)malloc(buffer->size);
@@ -64,7 +65,8 @@ int buffer_create(struct buffer *buffer, size_t size, const char *name) {
return (buffer->data == NULL);
}
-int buffer_from_file(struct buffer *buffer, const char *filename) {
+int buffer_from_file(struct buffer *buffer, const char *filename)
+{
FILE *fp = fopen(filename, "rb");
if (!fp) {
perror(filename);
@@ -88,7 +90,8 @@ int buffer_from_file(struct buffer *buffer, const char *filename) {
return 0;
}
-int buffer_write_file(struct buffer *buffer, const char *filename) {
+int buffer_write_file(struct buffer *buffer, const char *filename)
+{
FILE *fp = fopen(filename, "wb");
if (!fp) {
perror(filename);
@@ -104,7 +107,8 @@ int buffer_write_file(struct buffer *buffer, const char *filename) {
return 0;
}
-void buffer_delete(struct buffer *buffer) {
+void buffer_delete(struct buffer *buffer)
+{
assert(buffer);
if (buffer->name) {
free(buffer->name);