diff options
| author | Solomon Alan-Dei <alandei.solomon@gmail.com> | 2022-10-29 08:30:23 -0600 |
|---|---|---|
| committer | Martin Roth <martin.roth@amd.corp-partner.google.com> | 2022-11-08 22:51:36 +0000 |
| commit | a2503fa2e9c1c69495c29c4dfb00e7413952523d (patch) | |
| tree | 529a6f0d3008c6870537f80c7ead6aaa12c83088 /util/cbfstool/bpdt_formats | |
| parent | 37ccb2ce82d1c4782356a569737dd72bf9478db0 (diff) | |
util/cbfstool/bpdt_formats: Fix memory leak issues
The functions create_bpdt_hdr and create_cse_layout
in bpdt_1_6.c are defined to return pointers but
not integers as was previouly implemented.
Reported-by: Coverity(CID:1469323)
Reported-by: Coverity(CID:1469353)
Signed-off-by: Solomon Alan-Dei <alandei.solomon@gmail.com>
Change-Id: Idb78d94be7a75a25ad954f062e9e52b1f0b921dc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68986
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Diffstat (limited to 'util/cbfstool/bpdt_formats')
| -rw-r--r-- | util/cbfstool/bpdt_formats/bpdt_1_6.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/cbfstool/bpdt_formats/bpdt_1_6.c b/util/cbfstool/bpdt_formats/bpdt_1_6.c index b894936543..c5cedd3d8b 100644 --- a/util/cbfstool/bpdt_formats/bpdt_1_6.c +++ b/util/cbfstool/bpdt_formats/bpdt_1_6.c @@ -69,7 +69,7 @@ static bpdt_hdr_ptr create_bpdt_hdr(void) h->fit_tool_version.build = 0; h->fit_tool_version.hotfix = 0; - return 0; + return h; } static void print_bpdt_hdr(const bpdt_hdr_ptr ptr) @@ -159,7 +159,7 @@ static cse_layout_ptr create_cse_layout(const struct region *r) l->bp3_size = r[BP3].size; l->checksum = 0; /* unused */ - return 0; + return l; } static void print_cse_layout(const cse_layout_ptr ptr) |