diff options
author | Kaiyen Chang <kaiyen.chang@intel.corp-partner.google.com> | 2020-12-05 12:15:06 +0800 |
---|---|---|
committer | Patrick Georgi <pgeorgi@google.com> | 2020-12-08 16:56:00 +0000 |
commit | 62d73b6be596303fde9d57b3862d0d7c786bc805 (patch) | |
tree | 6a89e90ef47997c42a5415d850bfb16cf6c565fd /util/bincfg/bincfg.h | |
parent | f99f589ea9df2aca92d8b322094a551f98c64b67 (diff) |
soc/intel/common/gpio_defs: Add PAD_TRIG(OFF) in PAD_CFG_GPI_GPIO_DRIVER
Probabilistic interrupt storm is observed while kernel is configuring
the GPIO for SD card CD pin. The root cause is that the macro
PAD_CFG_GPI_GPIO_DRIVER isn't configuring trigger as PAD_TRIG(OFF).
The way GPIO interrupts are handled is:
1. Pad is configured as input in coreboot.
2. Pad IRQ information is passed in ACPI tables to kernel.
3. Kernel configures the required pad trigger.
Therefore, PAD_TRIG(OFF) should be added in PAD_CFG_GPI_GPIO_DRIVER
to turn off the trigger while pad is configured as input in coreboot
and then let kernel to configure the required pad trigger.
BUG=b:174336541
TEST=Run 1500 reboot iterations successfully without any interrupts
storm.
Signed-off-by: Kaiyen Chang <kaiyen.chang@intel.corp-partner.google.com>
Change-Id: Icc805f5cfe45e5cc991fb0561f669907ac454a03
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48302
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Diffstat (limited to 'util/bincfg/bincfg.h')
0 files changed, 0 insertions, 0 deletions