diff options
| author | Denis 'GNUtoo' Carikli <GNUtoo@no-log.org> | 2018-07-22 16:38:45 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2018-10-24 10:02:06 +0000 |
| commit | 48c24ce5eefe64b1aa82237f0a4be2772c686ef6 (patch) | |
| tree | 6995e4fbef1c62ec342536cd103d04c2d189493b /util/bincfg/bincfg.h | |
| parent | 78d338ccb9ca9d03e516c27beb3724be38d38ecf (diff) | |
util/bincfg: code cleanup: convert sym_table to a local variable
Global variables are considered a bad practice.
Change-Id: I652a8da75498f871a53eb7509f6145c4842e3373
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
Reviewed-on: https://review.coreboot.org/27810
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'util/bincfg/bincfg.h')
| -rw-r--r-- | util/bincfg/bincfg.h | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/util/bincfg/bincfg.h b/util/bincfg/bincfg.h index b8c668889e..c0e1242f83 100644 --- a/util/bincfg/bincfg.h +++ b/util/bincfg/bincfg.h @@ -37,13 +37,12 @@ struct blob { unsigned int lenactualblob; }; -static struct field *putsym (char const *, unsigned int); -static struct field *getsym (char const *); -static void yyerror (FILE* fp, char const *); -int yylex (void); +static struct field *putsym(field_ptr_t, char const *, unsigned int); +static struct field *getsym(field_ptr_t, char const *); +static void yyerror(FILE *, field_ptr_t, char const *); +int yylex(void); static struct blob *binary; -static struct field *sym_table; static struct field *sym_table_tail; #endif /* __BINCFG_H */ |