summaryrefslogtreecommitdiff
path: root/util/amdfwtool
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2023-02-01 19:21:11 +0100
committerFelix Held <felix-coreboot@felixheld.de>2023-02-04 03:15:37 +0000
commit9f5a5eefc32b6db7418955968f888ba3fccab3c7 (patch)
tree341cb369ccb9b8526e87ea626c9d6fec7dcd6db6 /util/amdfwtool
parentbc3261f8283ba11c389e8cfcc0089390a133c589 (diff)
util/amdfwtool: add comment about reused PSP firmware type 0x5f
On family 15h and 16h processors with PSP, the PSP firmware type 0x5f corresponds to AMD_FW_PSP_SMUSCS, while on family 17h and 19h this corresponds to AMD_FW_TPMLITE. Add comments to those two enum values to clarify this. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Ia5c125ec6a0eb548f58a457f9040278391d2101c Reviewed-on: https://review.coreboot.org/c/coreboot/+/72713 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Bao Zheng <fishbaozi@gmail.com> Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Diffstat (limited to 'util/amdfwtool')
-rw-r--r--util/amdfwtool/amdfwtool.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h
index d3d686669e..f30dce6fc2 100644
--- a/util/amdfwtool/amdfwtool.h
+++ b/util/amdfwtool/amdfwtool.h
@@ -68,8 +68,8 @@ typedef enum _amd_fw_type {
AMD_FW_MSMU = 0x5a,
AMD_FW_SPIROM_CFG = 0x5c,
AMD_FW_MPIO = 0x5d,
- AMD_FW_TPMLITE = 0x5f,
- AMD_FW_PSP_SMUSCS = 0x5f,
+ AMD_FW_TPMLITE = 0x5f, /* family 17h & 19h */
+ AMD_FW_PSP_SMUSCS = 0x5f, /* family 15h & 16h */
AMD_FW_DMCUB = 0x71,
AMD_FW_PSP_BOOTLOADER_AB = 0x73,
AMD_RIB = 0x76,