diff options
| author | Karthikeyan Ramasubramanian <kramasub@google.com> | 2023-03-09 17:39:31 -0700 |
|---|---|---|
| committer | Paul Fagerburg <pfagerburg@chromium.org> | 2023-03-15 17:30:15 +0000 |
| commit | 8d885612350b89daa1b11c34e77ae4544d6cf978 (patch) | |
| tree | 53c874a2f6e4d349cb2bbdb9fd436098fbbf86b8 /util/amdfwtool/amdfwtool.h | |
| parent | 225b4b3279aa0bbbb2528a26751d5cb0f52d24de (diff) | |
util/amdfwtool: Support not passing recovery/backup APCB
If Recovery/Backup APCB is not passed, then AMD_BIOS_APCB_BK entry is
not populated. But PSP expects that bios directory entry to be
populated. Also on mainboards where both APCB and recovery APCB are same
(eg. Skyrim), 2 copies of the same APCB are added to amdfw*.rom. Update
amdfwtool to support not passing recovery/backup APCB. If the recovery
APCB is not passed, then populate AMD_BIOS_APCB_BK entry and make it
point to the same offset as AMD_BIOS_APCB entry.
BUG=b:240696002
TEST=Build and boot to OS in Skyrim. Ensure that the device can enter
recovery mode. Perform multiple suspend/resume cycles.
Change-Id: I031ba817573cd35160f5e219b1b373ddce69aa6b
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73661
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'util/amdfwtool/amdfwtool.h')
| -rw-r--r-- | util/amdfwtool/amdfwtool.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index 2dc25a2560..23dc0ac5a6 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -405,6 +405,7 @@ typedef struct _amd_cb_config { bool recovery_ab_single_copy; bool need_ish; bool use_combo; + bool have_apcb_bk; enum platform soc_id; } amd_cb_config; |