summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2022-08-10 21:48:01 +0200
committerMartin Roth <martin.roth@amd.corp-partner.google.com>2022-08-26 17:29:08 +0000
commit875f7315f3fc2838b60607f334ecbb534d70ad94 (patch)
treec39e825af481cbca0f7cdcf79a5af356e0587c8d /tests
parentf26d7ea2e90f8b505d1aca2c8ef1041a2b2f9d83 (diff)
tests/memrange-test: Correct commentary on test_memrange_steal()
Currently, memranges_steal() steals at the lowest possible address. This is actually reflected by the test code that checks if the *base* of the READONLY_TAG range changes. Furthermore, the test ends with the memranges restored, so revise the comment on the final state. Change-Id: Idef71ce464280c6805145f229de9e8913ba850bc Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/66606 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-by: Jan Dabros <jsd@semihalf.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'tests')
-rw-r--r--tests/lib/memrange-test.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/lib/memrange-test.c b/tests/lib/memrange-test.c
index e812c74e24..f5922066df 100644
--- a/tests/lib/memrange-test.c
+++ b/tests/lib/memrange-test.c
@@ -461,7 +461,7 @@ static void test_memrange_holes(void **state)
* memory from region with READONLY_TAG.
*
* Example memory ranges (res_mock1) for test_memrange_steal.
- * Space marked with (/) is not covered by any region at the end of the test.
+ * Space marked with (/) is stolen during the test.
*
* +--------CACHEABLE_TAG--------+ <-0xE000
* | |
@@ -471,10 +471,10 @@ static void test_memrange_holes(void **state)
*
*
*
- * +--------READONLY_TAG---------+ <-0xFF0000
+ * +--------READONLY_TAG---------+ <-0xFF0000 <-stolen_base
+ * |/////////////////////////////| <-stolen_base + 0x4000
+ * | |
* | |
- * |/////////////////////////////| <-stolen_base
- * |/////////////////////////////| <-stolen_base + 0x4000
* +-----------------------------+ <-0x1000000
*
*