diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2022-06-24 21:54:46 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2022-08-17 14:08:52 +0000 |
| commit | f43e0e7247d8efe4737aa4ea6407956f295f5338 (patch) | |
| tree | 3b5a1ec00c797e217d4de9f23481bd88456215bd /src | |
| parent | e173f2bd5468439e5a37daf211f4ea7920650f4c (diff) | |
soc/amd/cezanne,picasso,sabrina/smihandler: add comment about SMN access
The SMI sleep entry handler will access the SMN space via the index/data
register at PCI config space offsets 0xb8 and 0xbc of the device at bus
0, device 0, function 0. This register pair is also used by other
software components running on the x86 cores after boot, so it should be
saved and restored at the beginning/end of the SMI handler if it
accesses SMN. The sleep entry SMI handler is a special case, since the
OS is already done at the moment we enter the sleep SMI handler which is
the last code that gets run on the x86 cores before entering S3/4/5.
BUG=b:237004699
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I0980562ef8a61489082a81c71d6d00d0786d68cb
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65529
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/amd/cezanne/smihandler.c | 5 | ||||
| -rw-r--r-- | src/soc/amd/mendocino/smihandler.c | 5 | ||||
| -rw-r--r-- | src/soc/amd/picasso/smihandler.c | 5 |
3 files changed, 15 insertions, 0 deletions
diff --git a/src/soc/amd/cezanne/smihandler.c b/src/soc/amd/cezanne/smihandler.c index a149e57fa9..2d59bd3adb 100644 --- a/src/soc/amd/cezanne/smihandler.c +++ b/src/soc/amd/cezanne/smihandler.c @@ -47,6 +47,11 @@ static void fch_apmc_smi_handler(void) mainboard_smi_apmc(cmd); } +/* + * Both the psp_notify_sx_info and the smu_sx_entry call will clobber the SMN index register + * during the SMN accesses. Since the SMI handler is the last thing that gets called before + * entering S3, this won't interfere with any indirect SMN accesses via the same register pair. + */ static void fch_slp_typ_handler(void) { uint32_t pci_ctrl, reg32; diff --git a/src/soc/amd/mendocino/smihandler.c b/src/soc/amd/mendocino/smihandler.c index 9fda2f9c1a..de09dc3e5a 100644 --- a/src/soc/amd/mendocino/smihandler.c +++ b/src/soc/amd/mendocino/smihandler.c @@ -47,6 +47,11 @@ static void fch_apmc_smi_handler(void) mainboard_smi_apmc(cmd); } +/* + * Both the psp_notify_sx_info and the smu_sx_entry call will clobber the SMN index register + * during the SMN accesses. Since the SMI handler is the last thing that gets called before + * entering S3, this won't interfere with any indirect SMN accesses via the same register pair. + */ static void fch_slp_typ_handler(void) { uint32_t pci_ctrl, reg32; diff --git a/src/soc/amd/picasso/smihandler.c b/src/soc/amd/picasso/smihandler.c index 08f805bf76..b4cab2d717 100644 --- a/src/soc/amd/picasso/smihandler.c +++ b/src/soc/amd/picasso/smihandler.c @@ -45,6 +45,11 @@ static void fch_apmc_smi_handler(void) mainboard_smi_apmc(cmd); } +/* + * Both the psp_notify_sx_info and the smu_sx_entry call will clobber the SMN index register + * during the SMN accesses. Since the SMI handler is the last thing that gets called before + * entering S3, this won't interfere with any indirect SMN accesses via the same register pair. + */ static void fch_slp_typ_handler(void) { uint32_t pci_ctrl, reg32; |