diff options
| author | Patrick Rudolph <patrick.rudolph@9elements.com> | 2023-07-21 09:09:07 +0200 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2023-08-11 13:07:51 +0000 |
| commit | b8abde7a8ef411f1439013932c7c25f3417efd5a (patch) | |
| tree | f6c72c2357bf25bf027ec94691345568a4474cc5 /src | |
| parent | 1f5d1682acd1ee3d782270bed77ac2e5a9f14b0a (diff) | |
soc/intel/alderlake: Disable PCIe clock gating
Intel requires that all enabled PCIe PCH ports have a CLK_REQ signal
connected. The CLK_REQ is used to wake the silicon when link entered
L1 link-state. L1 link-state is also entered on PCI-PM D3, even with
ASPM L1 disabled. When no CLK_REQ signal is used, for example when
it's using a free running clock the silicon will never wake from L1
link state. This will trigger a MCE.
Starting with FSP MR4 the UPD 'PchPcieClockGating' allows to work
around this issue by disabling ClockGating. Disabling ClockGating
should be avoided as the silicon draws more power when it is idle.
TEST: Verified on two boards, one with missing CLK_REQ on a PCH
root port, that the code does the right decision to disable
UPD PchPcieClockGating and PchPciePowerGating when necessary.
Change-Id: I673bbdbadc9afbed6a7bd5ce9f35dc70716d875b
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/76687
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/soc/intel/alderlake/fsp_params.c | 35 |
1 files changed, 35 insertions, 0 deletions
diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 4c8865c090..b64c302126 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -922,6 +922,41 @@ static void fill_fsps_pcie_params(FSP_S_CONFIG *s_cfg, s_cfg->PcieRpDetectTimeoutMs[i] = rp_cfg->pcie_rp_detect_timeout_ms; } s_cfg->PcieComplianceTestMode = CONFIG(SOC_INTEL_COMPLIANCE_TEST_MODE); + +#if CONFIG(FSP_TYPE_IOT) + /* + * Intel requires that all enabled PCH PCIe ports have a CLK_REQ signal connected. + * The CLK_REQ is used to wake the silicon when link entered L1 link-state. L1 + * link-state is also entered on PCI-PM D3, even with ASPM L1 disabled. + * When no CLK_REQ signal is used, for example when it's using a free running + * clock the Root port silicon will never wake from L1 link state. + * This will trigger a MCE. + * + * Starting with FSP MR4 the UPD 'PchPcieClockGating' allows to work around + * this issue by disabling ClockGating. Disabling ClockGating should be avoided + * as the silicon draws more power when it is idle. + */ + for (int i = 0; i < CONFIG_MAX_PCH_ROOT_PORTS; i++) { + bool clk_req_missing = false; + if (!(enable_mask & BIT(i))) + continue; + const struct pcie_rp_config *rp_cfg = &config->pch_pcie_rp[i]; + if (CONFIG(SOC_INTEL_COMPLIANCE_TEST_MODE)) { + clk_req_missing = true; + } else if (!rp_cfg->flags && rp_cfg->clk_src == 0 && rp_cfg->clk_req == 0) { + clk_req_missing = true; + } else if (rp_cfg->flags & PCIE_RP_CLK_REQ_UNUSED) { + clk_req_missing = true; + } + if (clk_req_missing) { + printk(BIOS_INFO, "PCH PCIe port %d has no CLK_REQ\n", i + 1); + printk(BIOS_INFO, "Disabling PCH PCIE ClockGating+PowerGating.\n"); + s_cfg->PchPcieClockGating = false; + s_cfg->PchPciePowerGating = false; + break; + } + } +#endif } static void fill_fsps_cpu_pcie_params(FSP_S_CONFIG *s_cfg, |