summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAlan Huang <alan-huang@quanta.corp-partner.google.com>2021-11-23 18:15:43 +0800
committerTim Wawrzynczak <twawrzynczak@chromium.org>2021-12-02 21:00:16 +0000
commitb1da051f17a0143802b63e7eb6dabccebc2d90b4 (patch)
treed243f6595cbb03c424c9863459809c56b9456890 /src
parentb974dd96b6bcefb21435c0afe19f8184aff2c74f (diff)
mb/google/brya/var/brask: Set PL and PsysPL
1. Set the PL1, PL2 and PL4 according to issue b:193864533 comment#55 and Intel's doc #626774. 2. Set PsysPL2 and PsysPmax according to the conclusion in issue b:193864533 comment#23 and comment#29. BUG=b:193864533 BRANCH=none TEST=Compare the measured power from adapter with the value of 'psys' from the command 'dump_intel_rapl_consumption'. Signed-off-by: Alan Huang <alan-huang@quanta.corp-partner.google.com> Change-Id: I9261902b8c892d0b866f326b24988039c1d30b56 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59576 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Diffstat (limited to 'src')
-rw-r--r--src/mainboard/google/brya/variants/brask/Makefile.inc1
-rw-r--r--src/mainboard/google/brya/variants/brask/ramstage.c62
2 files changed, 63 insertions, 0 deletions
diff --git a/src/mainboard/google/brya/variants/brask/Makefile.inc b/src/mainboard/google/brya/variants/brask/Makefile.inc
index d38141ca24..bc39984d6c 100644
--- a/src/mainboard/google/brya/variants/brask/Makefile.inc
+++ b/src/mainboard/google/brya/variants/brask/Makefile.inc
@@ -4,3 +4,4 @@ bootblock-y += gpio.c
romstage-y += gpio.c
ramstage-y += gpio.c
+ramstage-y += ramstage.c
diff --git a/src/mainboard/google/brya/variants/brask/ramstage.c b/src/mainboard/google/brya/variants/brask/ramstage.c
new file mode 100644
index 0000000000..f5105fea2c
--- /dev/null
+++ b/src/mainboard/google/brya/variants/brask/ramstage.c
@@ -0,0 +1,62 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#include <baseboard/variants.h>
+#include <chip.h>
+#include <device/device.h>
+#include <device/pci_ids.h>
+#include <device/pci_ops.h>
+#include <ec/google/chromeec/ec.h>
+#include <intelblocks/power_limit.h>
+
+const struct cpu_power_limits limits[] = {
+ /* SKU_ID, TDP (Watts), pl1_min, pl1_max, pl2_min, pl2_max, pl4 */
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, 15, 15000, 15000, 55000, 55000, 123000 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_6, 15, 15000, 15000, 55000, 55000, 123000 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, 28, 28000, 28000, 64000, 64000, 90000 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 28, 28000, 28000, 64000, 64000, 140000 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 45, 45000, 45000, 115000, 115000, 215000 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_1, 45, 45000, 45000, 95000, 95000, 125000 },
+};
+
+const struct system_power_limits sys_limits[] = {
+ /* SKU_ID, TDP (Watts), psys_pl2 (Watts) */
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, 15, 135 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_6, 15, 135 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, 28, 230 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 28, 230 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 45, 230 },
+ { PCI_DEVICE_ID_INTEL_ADL_P_ID_1, 45, 230 },
+};
+
+/*
+ * Psys_pmax considerations.
+ *
+ * Given the hardware design in brask, the serial shunt resistor is 0.005ohm.
+ * The full scale of hardware PSYS signal 1.6v maps to system current 13.52A
+ * instead of real system power. The equation is shown below:
+ * PSYS = 1.6v = (0.005ohm x 13.52A) x 50 (INA213, gain 50V/V) x R501/(R501 + R510)
+ * R501/(R501 + R510) = 0.47 = 15K / (15K + 16.9K)
+ *
+ * The Psys_pmax is a SW setting which tells IMVP9.1 the mapping b/w system input
+ * current and the actual system power. Since there is no voltage information
+ * from PSYS, different voltage input would map to different Psys_pmax settings:
+ * For Type-C 15V, the Psys_pmax should be 15v x 13.52A = 202.8W
+ * For Type-C 20V, the Psys_pmax should be 20v x 13.52A = 270.4W
+ * For a barrel jack, the Psys_pmax should be 19.5v x 13.52A = 263.6W
+ *
+ * Imagine that there is a type-c 100W (20V/5A) connected to DUT w/ full loading,
+ * and the Psys_pmax setting is 270.4W. Then IMVP9.1 can calculate the current system
+ * power = 270.4W * 5A / 13.52A = 100W, which is the actual system power.
+ */
+const struct psys_config psys_config = {
+ .efficiency = 97,
+ .psys_imax_ma = 13520,
+ .bj_volts_mv = 19500
+};
+
+void variant_devtree_update(void)
+{
+ size_t total_entries = ARRAY_SIZE(limits);
+ variant_update_psys_power_limits(limits, sys_limits, total_entries, &psys_config);
+ variant_update_power_limits(limits, total_entries);
+}