summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-07-22 18:17:33 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-08-03 05:31:59 +0000
commita457e352374e0efe4944bd1c81a3ca8ffd65b750 (patch)
treeaaec60fd63129b58bc974f6144bd172766d2de1d /src
parent10993c4ad40c92b2b2796856f9de2a5f602a2da9 (diff)
nb/intel/ironlake: Add QPI Physical Layer registers
Tested with BUILD_TIMELESS=1, Packard Bell MS2290 does not change. Change-Id: I44db564c757647f493e92d35602178ef8b722517 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43738 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src')
-rw-r--r--src/northbridge/intel/ironlake/ironlake.h10
-rw-r--r--src/northbridge/intel/ironlake/raminit.c26
2 files changed, 23 insertions, 13 deletions
diff --git a/src/northbridge/intel/ironlake/ironlake.h b/src/northbridge/intel/ironlake/ironlake.h
index d09ccccfd7..06e07716e9 100644
--- a/src/northbridge/intel/ironlake/ironlake.h
+++ b/src/northbridge/intel/ironlake/ironlake.h
@@ -75,6 +75,16 @@
*/
#define QPI_PHY_0 PCI_DEV(QUICKPATH_BUS, 2, 1)
+#define QPI_PLL_STATUS 0x50
+#define QPI_PLL_RATIO 0x54
+#define QPI_PHY_CAPABILITY 0x68 /* QPI Phys. Layer Capability */
+#define QPI_PHY_CONTROL 0x6c /* QPI Phys. Layer Control */
+#define QPI_PHY_INIT_STATUS 0x80 /* QPI Phys. Layer Initialization Status */
+#define QPI_PHY_PRIM_TIMEOUT 0x94 /* QPI Phys. Layer Primary Timeout Value */
+#define QPI_PHY_PWR_MGMT 0xd0 /* QPI Phys. Layer Power Management */
+#define QPI_PHY_EP_SELECT 0xe0 /* QPI Phys. Layer Electrical Parameter Select */
+#define QPI_PHY_EP_MCTR 0xf4 /* QPI Phys. Layer Electrical Parameter Misc. Control */
+
/* Device 0:2.0 PCI configuration space (Graphics Device) */
diff --git a/src/northbridge/intel/ironlake/raminit.c b/src/northbridge/intel/ironlake/raminit.c
index 65d682740f..704e66802a 100644
--- a/src/northbridge/intel/ironlake/raminit.c
+++ b/src/northbridge/intel/ironlake/raminit.c
@@ -3882,8 +3882,8 @@ void raminit(const int s3resume, const u8 *spd_addrmap)
MCHBAR32_OR(0x1890, 0x2000000);
MCHBAR32_OR(0x18b4, 0x8000);
- gav(pci_read_config32(QPI_PHY_0, 0x50)); // !!!!
- pci_write_config8(QPI_PHY_0, 0x54, 0x12);
+ gav(pci_read_config32(QPI_PHY_0, QPI_PLL_STATUS)); // !!!!
+ pci_write_config8(QPI_PHY_0, QPI_PLL_RATIO, 0x12);
gav(MCHBAR16(0x2c10));
MCHBAR16(0x2c10) = 0x412;
@@ -3893,8 +3893,8 @@ void raminit(const int s3resume, const u8 *spd_addrmap)
gav(MCHBAR8(0x2ca8)); // !!!!
MCHBAR32_AND_OR(0x1804, 0xfffffffc, 0x8400080);
- pci_read_config32(QPI_PHY_0, 0x6c); // !!!!
- pci_write_config32(QPI_PHY_0, 0x6c, 0x40a0a0);
+ pci_read_config32(QPI_PHY_0, QPI_PHY_CONTROL); // !!!!
+ pci_write_config32(QPI_PHY_0, QPI_PHY_CONTROL, 0x40a0a0);
gav(MCHBAR32(0x1c04)); // !!!!
gav(MCHBAR32(0x1804)); // !!!!
@@ -3904,16 +3904,16 @@ void raminit(const int s3resume, const u8 *spd_addrmap)
MCHBAR32(0x18d8) = 0x120000;
MCHBAR32(0x18dc) = 0x30a484a;
- pci_write_config32(QPI_PHY_0, 0xe0, 0x0);
- pci_write_config32(QPI_PHY_0, 0xf4, 0x9444a);
+ pci_write_config32(QPI_PHY_0, QPI_PHY_EP_SELECT, 0x0);
+ pci_write_config32(QPI_PHY_0, QPI_PHY_EP_MCTR, 0x9444a);
MCHBAR32(0x18d8) = 0x40000;
MCHBAR32(0x18dc) = 0xb000000;
- pci_write_config32(QPI_PHY_0, 0xe0, 0x60000);
- pci_write_config32(QPI_PHY_0, 0xf4, 0x0);
+ pci_write_config32(QPI_PHY_0, QPI_PHY_EP_SELECT, 0x60000);
+ pci_write_config32(QPI_PHY_0, QPI_PHY_EP_MCTR, 0x0);
MCHBAR32(0x18d8) = 0x180000;
MCHBAR32(0x18dc) = 0xc0000142;
- pci_write_config32(QPI_PHY_0, 0xe0, 0x20000);
- pci_write_config32(QPI_PHY_0, 0xf4, 0x142);
+ pci_write_config32(QPI_PHY_0, QPI_PHY_EP_SELECT, 0x20000);
+ pci_write_config32(QPI_PHY_0, QPI_PHY_EP_MCTR, 0x142);
MCHBAR32(0x18d8) = 0x1e0000;
gav(MCHBAR32(0x18dc)); // !!!!
@@ -3925,7 +3925,7 @@ void raminit(const int s3resume, const u8 *spd_addrmap)
}
MCHBAR32(0x188c) = 0x20bc09;
- pci_write_config32(QPI_PHY_0, 0xd0, 0x40b0c09);
+ pci_write_config32(QPI_PHY_0, QPI_PHY_PWR_MGMT, 0x40b0c09);
MCHBAR32(0x1a10) = 0x4200010e;
MCHBAR32_OR(0x18b8, 0x200);
gav(MCHBAR32(0x1918)); // !!!!
@@ -3935,8 +3935,8 @@ void raminit(const int s3resume, const u8 *spd_addrmap)
MCHBAR32(0x18b8) = 0xe00;
gav(MCHBAR32(0x182c)); // !!!!
MCHBAR32(0x182c) = 0x10202;
- gav(pci_read_config32(QPI_PHY_0, 0x94)); // !!!!
- pci_write_config32(QPI_PHY_0, 0x94, 0x10202);
+ gav(pci_read_config32(QPI_PHY_0, QPI_PHY_PRIM_TIMEOUT)); // !!!!
+ pci_write_config32(QPI_PHY_0, QPI_PHY_PRIM_TIMEOUT, 0x10202);
MCHBAR32_AND(0x1a1c, 0x8fffffff);
MCHBAR32_OR(0x1a70, 0x100000);