diff options
author | Elyes HAOUAS <ehaouas@noos.fr> | 2022-02-02 18:56:46 +0100 |
---|---|---|
committer | Felix Singer <felixsinger@posteo.net> | 2022-07-17 18:45:23 +0000 |
commit | 55be012ffdc79a259c6c180e58a6e24c744119f7 (patch) | |
tree | 94161b4e0a232b3d73f5c07340079d8ecdcda613 /src | |
parent | 8765c09a630e4df6d01ae460149921b03fe4f73b (diff) |
drivers: Get rid of unnecessary blank lines {before,after} brace
Change-Id: Ic1b38e93d919c1286a8d130700a4a2bfd6b55258
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/61557
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Diffstat (limited to 'src')
-rw-r--r-- | src/drivers/amd/agesa/heapmanager.c | 1 | ||||
-rw-r--r-- | src/drivers/amd/agesa/state_machine.c | 2 | ||||
-rw-r--r-- | src/drivers/aspeed/common/ast_dp501.c | 1 | ||||
-rw-r--r-- | src/drivers/aspeed/common/ast_mode.c | 1 | ||||
-rw-r--r-- | src/drivers/aspeed/common/ast_post.c | 6 | ||||
-rw-r--r-- | src/drivers/crb/tis.c | 1 | ||||
-rw-r--r-- | src/drivers/crb/tpm.c | 2 | ||||
-rw-r--r-- | src/drivers/generic/max98357a/chip.h | 1 | ||||
-rw-r--r-- | src/drivers/i2c/tpm/tpm.c | 1 | ||||
-rw-r--r-- | src/drivers/i2c/ww_ring/ww_ring.c | 1 | ||||
-rw-r--r-- | src/drivers/intel/fsp1_1/car.c | 1 | ||||
-rw-r--r-- | src/drivers/intel/fsp2_0/hand_off_block.c | 2 | ||||
-rw-r--r-- | src/drivers/intel/fsp2_0/header_display.c | 1 | ||||
-rw-r--r-- | src/drivers/intel/gma/opregion.c | 1 | ||||
-rw-r--r-- | src/drivers/intel/usb4/retimer/retimer.c | 1 | ||||
-rw-r--r-- | src/drivers/ipmi/ipmi_fru.c | 1 | ||||
-rw-r--r-- | src/drivers/net/ne2k.c | 1 | ||||
-rw-r--r-- | src/drivers/pc80/rtc/mc146818rtc.c | 1 | ||||
-rw-r--r-- | src/drivers/smmstore/store.c | 1 | ||||
-rw-r--r-- | src/drivers/spi/tpm/tis.c | 1 | ||||
-rw-r--r-- | src/drivers/tpm/ppi.c | 1 | ||||
-rw-r--r-- | src/drivers/usb/ehci.h | 1 |
22 files changed, 1 insertions, 29 deletions
diff --git a/src/drivers/amd/agesa/heapmanager.c b/src/drivers/amd/agesa/heapmanager.c index e2bafb9dce..2a6757d0dd 100644 --- a/src/drivers/amd/agesa/heapmanager.c +++ b/src/drivers/amd/agesa/heapmanager.c @@ -349,7 +349,6 @@ static AGESA_STATUS agesa_LocateBuffer(BIOS_HEAP_MANAGER *BiosHeapBasePtr, AllocParams->BufferLength = AllocNodePtr->BufferSize; return AGESA_SUCCESS; - } AGESA_STATUS HeapManagerCallout(UINT32 Func, UINTN Data, VOID *ConfigPtr) diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index db53a3ca12..af5ae5357e 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -159,7 +159,6 @@ static AGESA_STATUS romstage_dispatch(struct sysinfo *cb, { break; } - } return status; } @@ -222,7 +221,6 @@ static AGESA_STATUS ramstage_dispatch(struct sysinfo *cb, { break; } - } return status; } diff --git a/src/drivers/aspeed/common/ast_dp501.c b/src/drivers/aspeed/common/ast_dp501.c index 924ca57d9d..ba0833ca1a 100644 --- a/src/drivers/aspeed/common/ast_dp501.c +++ b/src/drivers/aspeed/common/ast_dp501.c @@ -146,7 +146,6 @@ static bool ast_launch_m68k(struct drm_device *dev) data = ast_mindwm(ast, 0x1e6e2100) & 0x01; if (!data) { - if (ast->dp501_fw_addr) { fw_addr = ast->dp501_fw_addr; len = 32*1024; diff --git a/src/drivers/aspeed/common/ast_mode.c b/src/drivers/aspeed/common/ast_mode.c index e5832e772e..3ab91c228e 100644 --- a/src/drivers/aspeed/common/ast_mode.c +++ b/src/drivers/aspeed/common/ast_mode.c @@ -26,7 +26,6 @@ static void ast_crtc_load_lut(struct drm_crtc *crtc) /* FIXME: Gamma cor 2.6 ? */ for (int i = 0; i < 256; i++) ast_load_palette_index(ast, i, i, i, i); - } static bool ast_get_vbios_mode_info(struct drm_crtc *crtc, struct drm_display_mode *mode, diff --git a/src/drivers/aspeed/common/ast_post.c b/src/drivers/aspeed/common/ast_post.c index e644d910f7..08bc42c833 100644 --- a/src/drivers/aspeed/common/ast_post.c +++ b/src/drivers/aspeed/common/ast_post.c @@ -788,8 +788,8 @@ static void finetuneDQSI(struct ast_private *ast) } reg_mcr18 = reg_mcr18 | (g_dqidly << 16) | (g_dqsip << 23); ast_moutdwm(ast, 0x1E6E0018, reg_mcr18); - } + static bool cbr_dll2(struct ast_private *ast, struct ast2300_dram_param *param) { u32 dllmin[2], dllmax[2], dlli, data, passcnt, retry = 0; @@ -1085,7 +1085,6 @@ static void get_ddr3_info(struct ast_private *ast, struct ast2300_dram_param *pa param->dram_config |= 0x0c; break; } - } static void ddr3_init(struct ast_private *ast, struct ast2300_dram_param *param) @@ -1226,7 +1225,6 @@ ddr3_init_start: ast_moutdwm(ast, 0x1E6E0050, 0x80000000); ast_moutdwm(ast, 0x1E6E0050, 0x00000000); #endif - } static void get_ddr2_info(struct ast_private *ast, struct ast2300_dram_param *param) @@ -1617,7 +1615,6 @@ ddr2_init_start: ast_moutdwm(ast, 0x1E6E0050, 0x80000000); ast_moutdwm(ast, 0x1E6E0050, 0x00000000); #endif - } static void ast_post_chip_2300(struct drm_device *dev) @@ -1883,7 +1880,6 @@ static void reset_mmc_2500(struct ast_private *ast) static void ddr3_init_2500(struct ast_private *ast, const u32 *ddr_table) { - ast_moutdwm(ast, 0x1E6E0004, 0x00000303); ast_moutdwm(ast, 0x1E6E0010, ddr_table[REGIDX_010]); ast_moutdwm(ast, 0x1E6E0014, ddr_table[REGIDX_014]); diff --git a/src/drivers/crb/tis.c b/src/drivers/crb/tis.c index c3cc3e790d..1167697651 100644 --- a/src/drivers/crb/tis.c +++ b/src/drivers/crb/tis.c @@ -52,7 +52,6 @@ int tis_open(void) int tis_close(void) { if (tpm_is_open) { - /* * Do we need to do something here, like waiting for a * transaction to stop? diff --git a/src/drivers/crb/tpm.c b/src/drivers/crb/tpm.c index 9c8f2498dc..1bdca0039f 100644 --- a/src/drivers/crb/tpm.c +++ b/src/drivers/crb/tpm.c @@ -110,7 +110,6 @@ static int crb_probe(void) */ static uint8_t crb_activate_locality(void) { - uint8_t locality = (read8(CRB_REG(0, CRB_REG_LOC_STATE)) >> 2) & 0x07; printk(BIOS_SPEW, "Active locality: %i\n", locality); @@ -174,7 +173,6 @@ static int crb_switch_to_ready(void) */ int tpm2_init(void) { - if (crb_probe()) { printk(BIOS_ERR, "TPM: Probe failed.\n"); return -1; diff --git a/src/drivers/generic/max98357a/chip.h b/src/drivers/generic/max98357a/chip.h index 1c4aa3d66c..66ebecfc5f 100644 --- a/src/drivers/generic/max98357a/chip.h +++ b/src/drivers/generic/max98357a/chip.h @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h> struct drivers_generic_max98357a_config { - /* ACPI _HID */ const char *hid; diff --git a/src/drivers/i2c/tpm/tpm.c b/src/drivers/i2c/tpm/tpm.c index b96099cccc..840b947ee7 100644 --- a/src/drivers/i2c/tpm/tpm.c +++ b/src/drivers/i2c/tpm/tpm.c @@ -346,7 +346,6 @@ static int recv_data(struct tpm_chip *chip, uint8_t *buf, size_t count) burstcnt); if (rc == 0) size += burstcnt; - } return size; } diff --git a/src/drivers/i2c/ww_ring/ww_ring.c b/src/drivers/i2c/ww_ring/ww_ring.c index 19aa6dae6f..98c162bb4d 100644 --- a/src/drivers/i2c/ww_ring/ww_ring.c +++ b/src/drivers/i2c/ww_ring/ww_ring.c @@ -375,7 +375,6 @@ static void ww_ring_init(unsigned int i2c_bus) for (i = 0, ledc = lp55231s; i < WW_RING_NUM_LED_CONTROLLERS; i++, ledc++) { - ledc->i2c_bus = i2c_bus; ledc->dev_addr = LP55231_I2C_BASE_ADDR + i; diff --git a/src/drivers/intel/fsp1_1/car.c b/src/drivers/intel/fsp1_1/car.c index 5d41a017b6..fc05b91987 100644 --- a/src/drivers/intel/fsp1_1/car.c +++ b/src/drivers/intel/fsp1_1/car.c @@ -19,7 +19,6 @@ void fill_postcar_frame(struct postcar_frame *pcf) * with different TSEG size configurations. */ top_of_ram = ALIGN_DOWN((uintptr_t)cbmem_top(), 8*MiB); postcar_frame_add_mtrr(pcf, top_of_ram - 8*MiB, 16*MiB, MTRR_TYPE_WRBACK); - } /* This is the romstage entry called from cpu/intel/car/romstage.c */ diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c index 6ea3aa3406..a40da7736c 100644 --- a/src/drivers/intel/fsp2_0/hand_off_block.c +++ b/src/drivers/intel/fsp2_0/hand_off_block.c @@ -134,7 +134,6 @@ struct hob_resource *find_resource_hob_by_guid(const struct hob_header *hob, for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR) continue; @@ -198,7 +197,6 @@ const void *fsp_find_extension_hob_by_guid(const uint8_t *guid, size_t *size) for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { - if (hob->type != HOB_TYPE_GUID_EXTENSION) continue; diff --git a/src/drivers/intel/fsp2_0/header_display.c b/src/drivers/intel/fsp2_0/header_display.c index d209e4ce2d..f286061da5 100644 --- a/src/drivers/intel/fsp2_0/header_display.c +++ b/src/drivers/intel/fsp2_0/header_display.c @@ -51,5 +51,4 @@ void fsp_print_header_info(const struct fsp_header *hdr) printk(BIOS_SPEW, "\tNotify phase offset 0x%zx\n", (size_t)hdr->notify_phase_entry_offset); } - } diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index dc99fd49e4..fe333fa674 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -290,7 +290,6 @@ static inline bool uses_relative_vbt_addr(opregion_header_t *header) static void opregion_add_ext_vbt(igd_opregion_t *opregion, uint8_t *ext_vbt, optionrom_vbt_t *vbt) { - opregion_header_t *header = &opregion->header; /* Copy VBT into extended VBT region (at offset 8 KiB) */ memcpy(ext_vbt, vbt, vbt->hdr_vbt_size); diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 52765750a9..7fb600d879 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -386,7 +386,6 @@ static void usb4_retimer_fill_ssdt(const struct device *dev) acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); for (dfp_port = 0; dfp_port < DFP_NUM_MAX; dfp_port++) { - if (!config->dfp[dfp_port].power_gpio.pin_count) { printk(BIOS_WARNING, "%s: No DFP%1d power GPIO for %s\n", __func__, dfp_port, dev_path(dev)); diff --git a/src/drivers/ipmi/ipmi_fru.c b/src/drivers/ipmi/ipmi_fru.c index d26a9b752b..822e5bfa23 100644 --- a/src/drivers/ipmi/ipmi_fru.c +++ b/src/drivers/ipmi/ipmi_fru.c @@ -571,5 +571,4 @@ void print_fru_areas(struct fru_info_str *fru_info_str) printk(BIOS_DEBUG, "chassis custom data %i: %s\n", count, *(chassis_info.chassis_custom + count)); } - } diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index 83d4ccfb22..235c90966e 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -124,7 +124,6 @@ static void str2mac(const char *str, unsigned char *mac) int acc = 0; do { - c = str[i]; if ((c >= '0') && (c <= '9')) { acc *= 16; diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index fd659f113b..f45a3a0d21 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -267,7 +267,6 @@ void set_boot_successful(void) /* If we are in normal mode set the boot count to 0 */ if (byte & RTC_BOOT_NORMAL) byte &= 0x0f; - } outb(byte, RTC_PORT(1)); diff --git a/src/drivers/smmstore/store.c b/src/drivers/smmstore/store.c index 6ba3f53695..482a045abf 100644 --- a/src/drivers/smmstore/store.c +++ b/src/drivers/smmstore/store.c @@ -169,7 +169,6 @@ static enum cb_err scan_end(struct region_device *store) return CB_ERR; return CB_SUCCESS; - } /* * Append data to region diff --git a/src/drivers/spi/tpm/tis.c b/src/drivers/spi/tpm/tis.c index 6465b40a0a..da4c1a882c 100644 --- a/src/drivers/spi/tpm/tis.c +++ b/src/drivers/spi/tpm/tis.c @@ -40,7 +40,6 @@ int tis_open(void) int tis_close(void) { if (tpm_is_open) { - /* * Do we need to do something here, like waiting for a * transaction to stop? diff --git a/src/drivers/tpm/ppi.c b/src/drivers/tpm/ppi.c index d3c2b1d81c..3e74314d85 100644 --- a/src/drivers/tpm/ppi.c +++ b/src/drivers/tpm/ppi.c @@ -581,7 +581,6 @@ void tpm_ppi_acpi_fill_ssdt(const struct device *dev) found = true; } } else { - for (size_t i = 0; i < ARRAY_SIZE(tpm2_funcs); i++) { ppib->func[tpm2_funcs[i]] = 1; if (ppib->pprq == tpm2_funcs[i]) diff --git a/src/drivers/usb/ehci.h b/src/drivers/usb/ehci.h index 9635460bdb..b9054cfb1c 100644 --- a/src/drivers/usb/ehci.h +++ b/src/drivers/usb/ehci.h @@ -42,7 +42,6 @@ struct ehci_caps { /* Section 2.3 Host Controller Operational Registers */ struct ehci_regs { - /* USBCMD: offset 0x00 */ u32 command; |